feat: Add genres config option to write main genre, sub-genre, or both#40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
genresconfig option (sub|main|both, defaultsub) controlling which Beatport genre fields are written to beets' multi-valuegenresfield.sub(default): sub-genre, falling back to the main genre — exactly the current behaviormain: always the main genreboth: main genre first, then sub-genreBeatportTracknow keepsgenreandsub_genreas separate fields; the selection happens in the plugin (_get_genres()), validated via confuseas_choice, so an invalid value fails loudly instead of silently mistagging.Verified end-to-end against the live Beatport API with track 16772903 from the issue (Trance (Main Floor) / Hard Trance):
track_for_idreturns both genres in order, a real singletonbeet import --search-idwritesgenres: Trance (Main Floor); Hard Tranceto the library, and the file itself carries both values as multi-value genre tags. The default mode was also live-verified to keep today's behavior.Fixes #37