Add CEG, DRAM, and TSM Base tokens#21
Conversation
📝 WalkthroughWalkthroughRegistry and settings token-source URLs are updated to commit 83f6e7d. The base token list timestamp and version.patch are advanced to 2026-05-20T00:00:00.000Z / patch 1, and three wrapped tokens (wtCEG, wtDRAM, wtTSM) plus matching tokenMap entries are added. ChangesRegistry Synchronization
🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
token-lists/base.json (1)
3-7:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winBump token list semantic version when adding new assets.
Line 3 updates the list snapshot and new tokens are added, but
versionremains1.1.0. Consumers that key refresh behavior offversionmay not detect this update reliably.🔧 Proposed fix
"version": { "major": 1, - "minor": 1, + "minor": 2, "patch": 0 },🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@token-lists/base.json` around lines 3 - 7, The token list was updated but the semantic version fields under "version" (version.major, version.minor, version.patch) were not incremented; update the semantic version in the token list JSON (e.g., bump patch or minor as appropriate) so consumers that rely on the version value can detect the update—locate the "version" object in token-lists/base.json and increment the correct field (major/minor/patch) to reflect the new snapshot timestamp.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@settings.yaml`:
- Line 40: The token-list URL in settings.yaml points to commit c08606126b...
while the registry uses commit 74498bac..., causing config drift; update the URL
in settings.yaml to reference the same registry cohort commit (replace the
commit SHA segment in the URL for the base.json token list with 74498bac...) so
the token source revision matches the registry commit.
---
Outside diff comments:
In `@token-lists/base.json`:
- Around line 3-7: The token list was updated but the semantic version fields
under "version" (version.major, version.minor, version.patch) were not
incremented; update the semantic version in the token list JSON (e.g., bump
patch or minor as appropriate) so consumers that rely on the version value can
detect the update—locate the "version" object in token-lists/base.json and
increment the correct field (major/minor/patch) to reflect the new snapshot
timestamp.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: be09494e-1e08-48ef-bcd4-1de51b6673f0
📒 Files selected for processing (3)
registrysettings.yamltoken-lists/base.json
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
settings.yaml (1)
40-40:⚠️ Potential issue | 🟠 Major | ⚡ Quick winPin
using-tokens-fromto the intended token-list commit.This URL currently points to
81caa6b..., but the PR objective says this pin should usec08606126bdd3930583992564eff7cdd744d1e53. That drift can make consumers read a different list revision than intended.🔧 Proposed fix
- - https://raw.githubusercontent.com/ST0x-Technology/st0x.registry/81caa6b3431c29b818052abd3a464f298a974c98/token-lists/base.json + - https://raw.githubusercontent.com/ST0x-Technology/st0x.registry/c08606126bdd3930583992564eff7cdd744d1e53/token-lists/base.json🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@settings.yaml` at line 40, The entry under using-tokens-from currently references the token-list URL with commit hash 81caa6b3431c29b818052abd3a464f298a974c98; update that URL so it uses the intended commit c08606126bdd3930583992564eff7cdd744d1e53 (i.e., replace the commit segment in the URL string with c08606126bdd3930583992564eff7cdd744d1e53) to pin the token list to the correct revision.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@token-lists/base.json`:
- Around line 358-376: Remove the unintended wtSGOV token entries that were
added outside the PR scope: locate the object with "symbol": "wtSGOV" in the
tokens array and the corresponding key in tokenMap and revert/remove those
entries so only the intended wtCEG, wtDRAM, and wtTSM additions remain; after
removal, verify the tokens and tokenMap counts return to the expected 17/17 and
ensure no other metadata (e.g., extensions.unwrappedAddress/receiptAddress) for
wtSGOV remains in the JSON.
---
Duplicate comments:
In `@settings.yaml`:
- Line 40: The entry under using-tokens-from currently references the token-list
URL with commit hash 81caa6b3431c29b818052abd3a464f298a974c98; update that URL
so it uses the intended commit c08606126bdd3930583992564eff7cdd744d1e53 (i.e.,
replace the commit segment in the URL string with
c08606126bdd3930583992564eff7cdd744d1e53) to pin the token list to the correct
revision.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 64a0130e-591b-43c7-a206-cd6a2481556b
📒 Files selected for processing (3)
registrysettings.yamltoken-lists/base.json
✅ Files skipped from review due to trivial changes (1)
- registry
Siddharth2207
changed the title
Siddharth2207
changed the title
There was a problem hiding this comment.
♻️ Duplicate comments (1)
settings.yaml (1)
40-40:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winToken source commit still misaligned with registry commit.
This is the same alignment issue flagged in the previous review. Line 40 points to commit
5109c5f154a3f673fcc0f6b0be60fb11b0cd70c9, while theregistryfile uses commit83f6e7dc40460877fbcd7a6c7ecd5c827589c6f1. This mismatch can cause config drift and result in loading an unintended token list revision.The two files should reference the same upstream commit to ensure consistency.
🔧 Proposed fix (after verifying the correct target commit)
If
registryhas the correct commit:- - https://raw.githubusercontent.com/ST0x-Technology/st0x.registry/5109c5f154a3f673fcc0f6b0be60fb11b0cd70c9/token-lists/base.json + - https://raw.githubusercontent.com/ST0x-Technology/st0x.registry/83f6e7dc40460877fbcd7a6c7ecd5c827589c6f1/token-lists/base.jsonIf
settings.yamlhas the correct commit, then updateregistryinstead.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@settings.yaml` at line 40, settings.yaml currently references commit 5109c5f154a3f673fcc0f6b0be60fb11b0cd70c9 while the registry references 83f6e7dc40460877fbcd7a6c7ecd5c827589c6f1; update the mismatched commit so both files point to the same upstream commit (either replace 5109c5f... in settings.yaml with 83f6e7d... or update the registry to 5109c5f... after verifying which is correct) to prevent config drift when loading the token list.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@settings.yaml`:
- Line 40: settings.yaml currently references commit
5109c5f154a3f673fcc0f6b0be60fb11b0cd70c9 while the registry references
83f6e7dc40460877fbcd7a6c7ecd5c827589c6f1; update the mismatched commit so both
files point to the same upstream commit (either replace 5109c5f... in
settings.yaml with 83f6e7d... or update the registry to 5109c5f... after
verifying which is correct) to prevent config drift when loading the token list.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: a34ef364-0d20-4763-8ee4-640bfb7f19d7
📒 Files selected for processing (3)
registrysettings.yamltoken-lists/base.json
💤 Files with no reviewable changes (1)
- token-lists/base.json
1 participant
Summary
Adds three new ST0x wrapped equities to the Base token list and pins Raindex registry URLs to this branch.
Merge order: This PR is stacked on #22 — Add wtSGOV to Base token list (
base→2026-05-22-add-sgov). Merge #22 first, then #21.Tokens added in this PR (
token-lists/base.json)0x3aF952888Cd89DAD3e8AF67cf4b7E740B36829C30x9a5D3cAeC90b0332b18C0B93fEF42F3F8C9182890xc6bc19df197ccd0db4c02ccd6aaff7b2ce698e08NYSE:CEGUS21037T10970x1A91Df4a970EBaB1bB4AF32Eb6d10509028eE4b80x96DE077262609298CD891E4Ab21bd34837dE33aB0x728734768a772c137a5364b10e61943de13921c4CBOE:DRAMUS77926X32000x71C66449d2528E23514A9c197BFD55Ae9DB3B7140x7001e2974F775f0Fd73a3D2e5914e591f3EC3fBB0x6553f9a5352ec3ca808138eab56fe4cc496ea5a9NYSE:TSMUS8740391003Each entry is in both
tokensandtokenMap. wtSGOV is included via the merged #22 branch (not introduced in this PR’s diff).Combined list after merge: version 1.1.1, timestamp 2026-05-22, 18 tokens / 18
tokenMapentries.Registry pins
settings.yaml:using-tokens-from→ commita37cc32(token list with SGOV + CEG, DRAM, TSM).registry: artifact URLs pinned to87ce6cd(settings commit that references that token list).Test plan
token-lists/base.jsonas JSON; confirm 18tokensand 18tokenMapkeysCEG.png,roundhill.png,TSM.pngonhttps://st0x.io/)