Skip to content

Make prod fork skips explicit#236

Open
TUPM96 wants to merge 1 commit into
ST0x-Technology:mainfrom
TUPM96:codex/prodfork-fail-fast-213
Open

Make prod fork skips explicit#236
TUPM96 wants to merge 1 commit into
ST0x-Technology:mainfrom
TUPM96:codex/prodfork-fail-fast-213

Conversation

@TUPM96

@TUPM96 TUPM96 commented May 25, 2026

Copy link
Copy Markdown

Closes #213.

Summary

  • fail fast with explicit errors when RPC_URL_BASE_FORK or FORK_BLOCK_BASE is missing
  • replace silent zero-address returns with visible vm.skip locally and hard failures when REQUIRE_PROD_DEPLOYED=1
  • apply the same visible/fail-fast behavior to inline multi-feed _existsOnFork guards
  • set REQUIRE_PROD_DEPLOYED=1 in the Rainix CI job so production fork coverage cannot pass vacuously

Validation

  • forge fmt --check test/src/concrete/ProdFork.t.sol
  • forge build
  • forge test --match-contract ProdForkTest --match-test testProdWtcoinOracleLatestAnswer -vv with fork env vars removed: fails as expected with MissingForkRpc()
  • RPC_URL_BASE_FORK=https://mainnet.base.org FORK_BLOCK_BASE=38996123 forge test --no-match-contract ProdForkTest: 121 passed
  • RPC_URL_BASE_FORK=https://mainnet.base.org FORK_BLOCK_BASE=46456804 REQUIRE_PROD_DEPLOYED=1 forge test --match-contract ProdForkTest --match-test testProdWtcoin(OracleDecimals|MultiOracleDecimals|MorphoConfig|PassthroughDecimals) -vv: 4 passed

Copilot AI review requested due to automatic review settings May 25, 2026 09:56
@coderabbitai

coderabbitai Bot commented May 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@TUPM96, we couldn't start this review because you've used your available PR reviews for now.

Your plan includes 1 review of capacity. Refill in 34 minutes and 5 seconds.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more review capacity refills, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ce6b33e2-2a2d-4b91-b8ff-8d4fc160aab6

📥 Commits

Reviewing files that changed from the base of the PR and between 3a24b5d and fb18454.

📒 Files selected for processing (2)
  • .github/workflows/rainix.yaml
  • test/src/concrete/ProdFork.t.sol
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[H8] [MEDIUM] ProdFork skip modifiers cause whole-test silent vacuous-pass when fork env vars are missing or addresses are zero

2 participants