Make prod fork skips explicit#236
Conversation
|
Warning Review limit reached
Your plan includes 1 review of capacity. Refill in 34 minutes and 5 seconds. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more review capacity refills, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Closes #213.
Summary
RPC_URL_BASE_FORKorFORK_BLOCK_BASEis missingvm.skiplocally and hard failures whenREQUIRE_PROD_DEPLOYED=1_existsOnForkguardsREQUIRE_PROD_DEPLOYED=1in the Rainix CI job so production fork coverage cannot pass vacuouslyValidation
forge fmt --check test/src/concrete/ProdFork.t.solforge buildforge test --match-contract ProdForkTest --match-test testProdWtcoinOracleLatestAnswer -vvwith fork env vars removed: fails as expected withMissingForkRpc()RPC_URL_BASE_FORK=https://mainnet.base.org FORK_BLOCK_BASE=38996123 forge test --no-match-contract ProdForkTest: 121 passedRPC_URL_BASE_FORK=https://mainnet.base.org FORK_BLOCK_BASE=46456804 REQUIRE_PROD_DEPLOYED=1 forge test --match-contract ProdForkTest --match-test testProdWtcoin(OracleDecimals|MultiOracleDecimals|MorphoConfig|PassthroughDecimals) -vv: 4 passed