fixed spread#7
Merged
hardyjosh merged 23 commits intoApr 17, 2026
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughRegistry entries for two existing strategy files were updated to a new upstream commit ( Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant GUI as "GUI / Deployment"
participant Strategy as "st0x-fixed-spread.rain"
participant Oracle as "Signed Context Oracle"
participant Orderbook as "RAINDEX Orderbook"
GUI->>Strategy: deploy scenario with params (baseline-multiplier, min/max-price, max-staleness, input/output)
Strategy->>Oracle: fetch signed-context (schema v1) -> request price, publish_time, signer
Oracle-->>Strategy: signed context (oracle-price, publish-time, signer, schema)
Strategy->>Strategy: verify signer, schema, publish_time ≤ now, age ≤ max-staleness
Strategy->>Strategy: assert oracle-price > 0 and min-price < oracle-price < max-price
Strategy->>Strategy: compute IO = oracle-price * baseline-multiplier
Strategy->>Orderbook: provide IO (offer-amount, io price) for `base` order
Orderbook-->>GUI: reflect orderbook quoting / deployment status
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@strategy/st0x-fixed-spread.rain`:
- Line 50: Update the user-facing description strings that contain
grammar/spelling errors: replace "Deploy an fixed-spread strategy on Base using
St0x price feeds to sell shares." (the line with the description: key) with the
correct phrasing such as "Deploy a fixed-spread strategy on Base using St0x
price feeds to sell shares." and make the same correction for the second
occurrence around the description at the other location (the second description:
key near line 104).
- Around line 121-135: The UI tunable "oracle-price-timeout" is defined but
never referenced by the strategy; remove the dead field by deleting the binding
block for "oracle-price-timeout" (the block starting with "binding:
oracle-price-timeout" / "name: Oracle Price Timeout") from the Rainlang config
so user input is not exposed as a no-op, or alternatively add usage of the
variable (e.g., reference oracle-price-timeout in the strategy logic where
oracle freshness is validated) if you intend to honor the timeout.
- Around line 21-30: The code is recursively calling call<'baseline-fn'>()
(which resolves back to the same function) causing infinite recursion; replace
those call<'baseline-fn'>() invocations with the already-bound baseline variable
(bound via call<'st0x-oracle-baseline'>()) so the function uses the computed
baseline value instead of re-invoking baseline-fn; update occurrences where
baseline-fn is invoked (look for call<'baseline-fn'>() in the body of
st0x-oracle-baseline and related code) to reference baseline.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5d359360-f46f-4f69-ac8a-c4e5f2845536
📒 Files selected for processing (2)
strategy/registrystrategy/st0x-fixed-spread.rain
There was a problem hiding this comment.
♻️ Duplicate comments (2)
strategy/st0x-fixed-spread.rain (2)
249-255:⚠️ Potential issue | 🔴 CriticalReplace self-recursive
call<'baseline-fn>()withbaselinevariable.This is an infinite recursion bug. When
baseline-fnis bound to'st0x-feed-price':
#calculate-iocallscall<'baseline-fn>()→ resolves tocall<'st0x-feed-price>()#st0x-feed-pricecomputesbaselinebut then callscall<'baseline-fn>()again- This resolves back to
call<'st0x-feed-price>()→ infinite loopThe
baselinevariable is already correctly bound to the oracle price. Use it instead of recursively calling the same function.🐛 Proposed fix
`#st0x-feed-price` baseline: call<'st0x-oracle-baseline>() - _: mul(call<'baseline-fn>() baseline-multiplier); + _: mul(baseline baseline-multiplier); `#st0x-feed-price-inv` baseline: call<'st0x-oracle-baseline>() - _: inv(mul(call<'baseline-fn>() baseline-multiplier)); + _: inv(mul(baseline baseline-multiplier));🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@strategy/st0x-fixed-spread.rain` around lines 249 - 255, The two rule blocks `#st0x-feed-price` and `#st0x-feed-price-inv` currently call call<'baseline-fn>() causing self-recursion when baseline-fn is bound to 'st0x-feed-price'; replace those recursive call<'baseline-fn>() uses with the already-bound baseline variable (i.e., use baseline where call<'baseline-fn>() appears in both mul(...) and inv(mul(...)) expressions) so the oracle price variable is reused instead of re-invoking the same rule.
50-50:⚠️ Potential issue | 🟡 MinorFix user-facing description typos.
Line 50: "an fixed-spread" should be "a fixed-spread".
Line 104: "an fixed-spread trategy" should be "a fixed-spread strategy" (two typos).✏️ Proposed fix
- description: Deploy an fixed-spread strategy on Base using St0x price feeds to sell shares. + description: Deploy a fixed-spread strategy on Base using St0x price feeds to sell shares.At line 104:
- description: Deploy an fixed-spread trategy on Base using St0x price feeds to buy shares. + description: Deploy a fixed-spread strategy on Base using St0x price feeds to buy shares.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@strategy/st0x-fixed-spread.rain` at line 50, Fix the user-facing typos in the strategy description fields: change "an fixed-spread" to "a fixed-spread" in the description key (the line starting with description:) and correct the second occurrence "an fixed-spread trategy" to "a fixed-spread strategy" wherever that string appears (search for the phrase "fixed-spread" to locate both places).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@strategy/st0x-fixed-spread.rain`:
- Around line 249-255: The two rule blocks `#st0x-feed-price` and
`#st0x-feed-price-inv` currently call call<'baseline-fn>() causing self-recursion
when baseline-fn is bound to 'st0x-feed-price'; replace those recursive
call<'baseline-fn>() uses with the already-bound baseline variable (i.e., use
baseline where call<'baseline-fn>() appears in both mul(...) and inv(mul(...))
expressions) so the oracle price variable is reused instead of re-invoking the
same rule.
- Line 50: Fix the user-facing typos in the strategy description fields: change
"an fixed-spread" to "a fixed-spread" in the description key (the line starting
with description:) and correct the second occurrence "an fixed-spread trategy"
to "a fixed-spread strategy" wherever that string appears (search for the phrase
"fixed-spread" to locate both places).
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 28e468d2-0637-4b38-9ae4-f884a09f6f15
📒 Files selected for processing (2)
strategy/registrystrategy/st0x-fixed-spread.rain
🚧 Files skipped from review as they are similar to previous changes (1)
- strategy/registry
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIxed spread strategy for st0x
Summary by CodeRabbit
New Features
Chores