Skip to content

chore: add PR template#17

Closed
0xgleb wants to merge 1 commit into
masterfrom
chore/pr-template
Closed

chore: add PR template#17
0xgleb wants to merge 1 commit into
masterfrom
chore/pr-template

Conversation

@0xgleb

@0xgleb 0xgleb commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Motivation

The repo had no PR template, so PRs opened with empty or auto-generated bodies
(several in this stack did) and descriptions drifted to ad hoc formats. A
checked-in template gives every new PR a consistent skeleton.

Solution

  • Adds .github/PULL_REQUEST_TEMPLATE.md with ## Motivation and ## Solution
    sections plus short guidance comments.
  • GitHub applies it as the default body for new PRs once this merges to master.

Standalone chore; sits below the jobs ADR stack on chore/bump-up-cqrs-es.

Summary by CodeRabbit

  • Chores
    • Updated the pull request template to add structured "Motivation" and "Solution" sections plus inline guidance prompting authors to explain need, design approach, edge cases, trade-offs, and include supporting links.

Closes RAI-920.

0xgleb commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label add-to-gt-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

This PR introduces a pull request template file at .github/PULL_REQUEST_TEMPLATE.md. The template includes "Motivation" and "Solution" sections with embedded guidance comments prompting authors to explain their approach, handle edge cases, and link supporting issues or context.

Changes

PR Template Setup

Layer / File(s) Summary
Pull request template sections and guidance
.github/PULL_REQUEST_TEMPLATE.md
Template file defines Motivation and Solution section headers with instructional comments guiding authors to document approach, edge cases, and issue linkage.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding a PR template to the repository's .github directory.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/pr-template

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@0xgleb 0xgleb changed the base branch from master to graphite-base/17 June 9, 2026 21:21
@0xgleb 0xgleb force-pushed the chore/pr-template branch from 1e2151d to 5b1ff80 Compare June 9, 2026 21:22
@0xgleb 0xgleb changed the base branch from graphite-base/17 to chore/bump-up-cqrs-es June 9, 2026 21:22
@0xgleb 0xgleb self-assigned this Jun 9, 2026
@0xgleb 0xgleb marked this pull request as ready for review June 9, 2026 22:20
@0xgleb 0xgleb changed the base branch from chore/bump-up-cqrs-es to graphite-base/17 June 9, 2026 22:56
@0xgleb 0xgleb requested review from JuaniRios and findolor June 9, 2026 22:59
@0xgleb 0xgleb added the documentation Improvements or additions to documentation label Jun 9, 2026 — with Graphite App
@0xgleb 0xgleb force-pushed the chore/pr-template branch from 5b1ff80 to 86e3950 Compare June 9, 2026 23:24
@0xgleb 0xgleb force-pushed the graphite-base/17 branch from 99bbb51 to 42b178c Compare June 9, 2026 23:24
@0xgleb 0xgleb changed the base branch from graphite-base/17 to fix/sqlite-es-snapshot-sequence June 9, 2026 23:24
@0xgleb 0xgleb force-pushed the chore/pr-template branch from 86e3950 to 5911183 Compare June 9, 2026 23:55
@0xgleb 0xgleb force-pushed the fix/sqlite-es-snapshot-sequence branch from 42b178c to 5bc8232 Compare June 9, 2026 23:55
@0xgleb 0xgleb force-pushed the chore/pr-template branch from 5911183 to 8d89441 Compare June 10, 2026 02:50
@0xgleb 0xgleb force-pushed the fix/sqlite-es-snapshot-sequence branch from 5bc8232 to 87d8fcd Compare June 10, 2026 02:50
@linear-code

linear-code Bot commented Jun 10, 2026

Copy link
Copy Markdown

RAI-920

@findolor findolor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@graphite-app graphite-app Bot changed the base branch from fix/sqlite-es-snapshot-sequence to graphite-base/17 June 10, 2026 17:30
@0xgleb 0xgleb force-pushed the graphite-base/17 branch from 87d8fcd to 00d5969 Compare June 10, 2026 17:39
@0xgleb 0xgleb force-pushed the chore/pr-template branch from 8d89441 to 120f695 Compare June 10, 2026 17:39
@0xgleb 0xgleb changed the base branch from graphite-base/17 to fix/sqlite-es-snapshot-sequence June 10, 2026 17:39
@graphite-app graphite-app Bot changed the base branch from fix/sqlite-es-snapshot-sequence to graphite-base/17 June 10, 2026 19:15
@0xgleb 0xgleb force-pushed the graphite-base/17 branch from 00d5969 to 4a866fb Compare June 10, 2026 19:15
@0xgleb 0xgleb force-pushed the chore/pr-template branch from 120f695 to b9ffe93 Compare June 10, 2026 19:15
@graphite-app graphite-app Bot changed the base branch from graphite-base/17 to master June 10, 2026 19:16
@graphite-app

graphite-app Bot commented Jun 10, 2026

Copy link
Copy Markdown

Merge activity

  • Jun 10, 7:16 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
  • Jun 10, 7:22 PM UTC: 0xgleb added this pull request to the Graphite merge queue.
  • Jun 10, 7:22 PM UTC: CI is running for this pull request on a draft pull request (#23) due to your merge queue CI optimization settings.
  • Jun 10, 7:43 PM UTC: Merged by the Graphite merge queue via draft PR: #23.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/PULL_REQUEST_TEMPLATE.md:
- Line 1: The markdownlint warning MD041 for the template heading is a false
positive; suppress it either globally by adding a config that sets "MD041":
false in your markdownlint config (e.g., .markdownlint.json) or locally by
adding an inline file-level disable comment at the top of the template (e.g.,
add <!-- markdownlint-disable MD041 --> before the existing "## Motivation"
heading) so the lint tool ignores the missing H1 for this PR template.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: ff5c87b2-4cfe-4b80-b1a7-f9362228d20a

📥 Commits

Reviewing files that changed from the base of the PR and between 5b1ff80 and b9ffe93.

📒 Files selected for processing (1)
  • .github/PULL_REQUEST_TEMPLATE.md
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
  • GitHub Check: hooks
  • GitHub Check: check
  • GitHub Check: fmt
  • GitHub Check: examples
  • GitHub Check: test
  • GitHub Check: clippy
  • GitHub Check: test
  • GitHub Check: examples
  • GitHub Check: check
  • GitHub Check: clippy
  • GitHub Check: fmt
  • GitHub Check: hooks
🧰 Additional context used
🪛 markdownlint-cli2 (0.22.1)
.github/PULL_REQUEST_TEMPLATE.md

[warning] 1-1: First line in a file should be a top-level heading

(MD041, first-line-heading, first-line-h1)

🔇 Additional comments (2)
.github/PULL_REQUEST_TEMPLATE.md (2)

1-4: LGTM!


6-10: LGTM!

@@ -0,0 +1,10 @@
## Motivation

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial | 💤 Low value

Markdownlint warning is a false positive for PR templates.

The markdownlint hint flagging the lack of a top-level (H1) heading is expected and safe to suppress. GitHub PR templates conventionally use H2 (##) headings because the PR title serves as the implicit H1. Adding an H1 to the template would create a duplicate top-level heading in the rendered PR body.

If you want to suppress this warning, add a .markdownlint.json or .markdownlintrc configuration:

{
  "MD041": false
}

Or scope the suppression to this file specifically via inline comment or glob pattern.

🧰 Tools
🪛 markdownlint-cli2 (0.22.1)

[warning] 1-1: First line in a file should be a top-level heading

(MD041, first-line-heading, first-line-h1)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/PULL_REQUEST_TEMPLATE.md at line 1, The markdownlint warning MD041
for the template heading is a false positive; suppress it either globally by
adding a config that sets "MD041": false in your markdownlint config (e.g.,
.markdownlint.json) or locally by adding an inline file-level disable comment at
the top of the template (e.g., add <!-- markdownlint-disable MD041 --> before
the existing "## Motivation" heading) so the lint tool ignores the missing H1
for this PR template.

@graphite-app graphite-app Bot closed this Jun 10, 2026
@graphite-app graphite-app Bot deleted the chore/pr-template branch June 10, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants