Fix footer spacing issue - add bottom padding to prevent content overlap#42
Open
yashmakra wants to merge 6 commits into
Open
Fix footer spacing issue - add bottom padding to prevent content overlap#42yashmakra wants to merge 6 commits into
yashmakra wants to merge 6 commits into
Conversation
yashmakra
commented
Jul 22, 2025
- Added 80px bottom padding to main content container
- Added z-index to footer for proper layering
- Added margin to video elements for better spacing
- Resolves cramped layout between content and fixed footer
- Added 80px bottom padding to main content container - Added z-index to footer for proper layering - Added margin to video elements for better spacing - Resolves cramped layout between content and fixed footer
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
SGCODEX
requested changes
Jul 23, 2025
SGCODEX
left a comment
Owner
There was a problem hiding this comment.
Heyy @yashmakra, The code looks clean and PR looks great too. Please attach some screenshots of the working code. Also you have made changes to 4 files (can be seen in the image below), please sync your fork and revert back the changes made to LEARN.md, README.md, code/new_models/readme.md. Please just work on your code file for this PR otherwise there will be version error during merging this PR. Please sync fork and revert back changes made to those 3 files. Rest looks good, Thank you.
Owner
|
ignore #32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.