Bug Fixes - #86
Bug Fixes#86
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
It includes an apparently unintended full deletion of MIGRATION.md and introduces new untranslated user-facing strings plus a machine-specific VS Code setting entry.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR targets several UI/behavior fixes across admin/profile and inventory flows in the SEED Angular app, primarily around organization selection behavior, inventory list column-def handling, and label visibility consistency.
Changes:
- Add searchable filtering for large
<mat-select>lists in the admin profile page (orgs/users/access level instances). - Prevent switching into organizations where the current user is not a member, and visually mark those orgs in the org selector.
- Fix inventory list grid column-def mutation issues and ensure only
show_in_listlabels display in list/detail contexts.
File summaries
| File | Description |
|---|---|
| src/app/modules/profile/admin/admin.component.ts | Adds search FormControls and filtering/sorting getters to support searchable admin selects. |
| src/app/modules/profile/admin/admin.component.html | Adds inline search inputs inside several <mat-select> dropdown panels. |
| src/app/modules/inventory-list/list/grid/grid.component.ts | Preserves raw API column defs separately and filters displayed labels via show_in_list. |
| src/app/modules/inventory-detail/detail/header.component.ts | Adds shownLabels getter to filter labels by show_in_list. |
| src/app/modules/inventory-detail/detail/header.component.html | Switches label rendering to use shownLabels. |
| src/app/layout/common/organization-selector/organization-selector.component.ts | Sorts org list; blocks switching to orgs without user_role and shows snackbar message. |
| src/app/layout/common/organization-selector/organization-selector.component.html | Highlights non-member orgs in red and adds a tooltip explaining why. |
| MIGRATION.md | Deleted entirely (appears unrelated to stated bug-fix scope). |
| .vscode/settings.json | Adds auto-approve entry for a local .venv/bin/python path. |
Review details
Suppressed comments (4)
src/app/modules/profile/admin/admin.component.html:178
- The new search placeholder is hardcoded and bypasses Transloco. Use
t('Search instances…')so the string participates in i18n.
<input class="h-8 w-full bg-transparent outline-none" [formControl]="aliSearch" placeholder="Search instances…" />
src/app/modules/profile/admin/admin.component.html:209
- This repeated search placeholder is hardcoded and bypasses Transloco. Use
t('Search organizations…')so the string participates in i18n.
<input class="h-8 w-full bg-transparent outline-none" [formControl]="orgSearch" placeholder="Search organizations…" />
src/app/modules/profile/admin/admin.component.html:220
- This repeated search placeholder is hardcoded and bypasses Transloco. Use
t('Search users…')so the string participates in i18n.
<input class="h-8 w-full bg-transparent outline-none" [formControl]="userSearch" placeholder="Search users…" />
src/app/modules/profile/admin/admin.component.html:249
- This repeated search placeholder is hardcoded and bypasses Transloco. Use
t('Search organizations…')so the string participates in i18n.
<input class="h-8 w-full bg-transparent outline-none" [formControl]="orgSearch" placeholder="Search organizations…" />
- Files reviewed: 9/9 changed files
- Comments generated: 6
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Uh oh!
There was an error while loading. Please reload this page.