Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Add sslmode=require for non-localhost connections (production) | ||
| if "sslmode=" not in url and "localhost" not in url and "127.0.0.1" not in url: | ||
| url = f"{url}{'&' if '?' in url else '?'}sslmode=require" |
There was a problem hiding this comment.
The new _get_db_url appends sslmode=require whenever the URL host is not literally localhost or 127.0.0.1. Many existing local/docker deployments connect to Postgres over service names such as db or postgres without TLS. Those URLs will now always receive sslmode=require, causing Alembic to fail to connect because the server is not configured for SSL. This change will break migrations in common non‑TLS environments and should be guarded by an explicit setting rather than inferring from the hostname.
Useful? React with 👍 / 👎.
1 participant
No description provided.