Feature/gp fast gaus opt#97
Open
mvicenzi wants to merge 4 commits into
Open
Conversation
Exploiting function symmetry.
Production release
PetrilloAtWork
approved these changes
Feb 9, 2026
PetrilloAtWork
left a comment
PetrilloAtWork
left a comment
Member
There was a problem hiding this comment.
Disclaimer: I am the author of the fix.
4 tasks
There was a problem hiding this comment.
Pull request overview
This PR updates ICARUS’s fast approximate Gaussian translator (util::FastAndPoorGauss) and includes a couple of small documentation/formatting adjustments in utilities headers. The change is intended to support downstream usage (ref. icaruscode PR #892).
Changes:
- Update
util::FastAndPoorGaussto use a symmetric transform (viastd::copysign/std::abs) and adjust sampling-table generation accordingly. - Reformat a Doxygen note block in
SampledFunction.h(but introduces a small typo). - Add a blank line in
WaveformOperations.h(currently with trailing whitespace).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| icarusalg/Utilities/FastAndPoorGauss.h | Changes Gaussian transform/table generation; needs an index clamping fix to avoid out-of-bounds access. |
| icarusalg/Utilities/SampledFunction.h | Doxygen comment reformat; contains a “di” → “do” typo. |
| icarusalg/Utilities/WaveformOperations.h | Adds spacing in a Doxygen group; trailing whitespace should be removed. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
85
to
88
| /// @name Operations relative to the baseline | ||
| /// @{ | ||
|
|
||
| /// Returns the current baseline. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the fast Gaussian random generator.
This is required by: