feat: Add ADP specific tools

.changeset/fiori-mcp-server-adp-tools.md

@@ -0,0 +1,5 @@
+---
+"@sap-ux/fiori-mcp-server": minor
+---
+
+FEAT: add ADP top-level tools (generate_adaptation_project, open_adaptation_editor, adp_controller_extension)

packages/fiori-mcp-server/jest.config.mjs

@@ -5,7 +5,7 @@ export default {
     setupFilesAfterEnv: ['<rootDir>/test/jest.setup.ts'],
     modulePathIgnorePatterns: [...baseConfig.modulePathIgnorePatterns, '<rootDir>/test/data/'],
     transformIgnorePatterns: [
-        'node_modules/(?!(@huggingface|@sap-ux|@sap-ux-private|@sap/ux-specification|@sap/ux-cds-compiler-facade)/)'
+        'node_modules/(?!(@huggingface|@sap-ux|@sap-ux-private|@sap/ux-specification|@sap/ux-cds-compiler-facade|@sap-devx)/)'
     ],
     // Routes @sap/ux-cds-compiler-facade to .mjs ESM mock
     resolver: '<rootDir>/jest.resolver.cjs',
@@ -24,6 +24,7 @@ export default {
         // Stub fe-fpm-writer to prevent the CJS require chain: ux-specification → fe-fpm-writer →
         // fiori-annotation-api → @sap/ux-cds-compiler-facade which conflicts with the ESM mock
         '^@sap-ux/fe-fpm-writer$': '<rootDir>/test/__mocks__/@sap-ux/fe-fpm-writer.cjs',
+        '^@sap-ux/adp-tooling$': '<rootDir>/test/__mocks__/@sap-ux/adp-tooling.cjs',
         '^@sap/ux-specification$': '<rootDir>/test/__mocks__/@sap/ux-specification.mjs',
         ...baseConfig.moduleNameMapper,
         '^@huggingface/transformers$': '<rootDir>/test/__mocks__/@huggingface/transformers.cjs'

packages/fiori-mcp-server/package.json

@@ -22,8 +22,9 @@
     "license": "Apache-2.0",
     "main": "dist/index.js",
     "scripts": {
+        "build-esbuild-base": "esbuild --bundle --platform=node --target=node20 --outdir=dist --external:vscode --external:@lancedb/lancedb --external:@xenova/transformers --external:@sap-ux/fiori-docs-embeddings  --external:@sap-ux/store --external:playwright-core --main-fields=module,main src/index.ts",
         "build-bundle": "node scripts/bundle.mjs",
-        "build-dev": "NODE_ENV=development node scripts/bundle.mjs",
+        "build-dev": "pnpm run build-esbuild-base --sourcemap=inline",
         "build-compile": "tsc --noEmit",
         "build": "npm-run-all build-compile build-bundle",
         "watch": "tsc --watch",
@@ -47,7 +48,8 @@
         "dist",
         "!dist/**/*.map",
         "assets/icon.svg",
-        "assets/icon.png"
+        "assets/icon.png",
+        "skills"
     ],
     "bin": {
         "fiori-mcp": "./dist/index.js"
@@ -82,13 +84,15 @@
         "@types/json-schema": "7.0.15",
         "@types/mem-fs": "1.1.2",
         "@types/mem-fs-editor": "7.0.1",
+        "@sap-ux/adp-tooling": "workspace:*",
         "cross-env": "10.1.0",
         "esbuild": "0.27.4",
         "i18next": "25.10.10",
         "mem-fs": "2.1.0",
         "mem-fs-editor": "9.4.0",
         "npm-run-all2": "8.0.4",
         "os-name": "4.0.1",
+        "playwright-core": "1.58.2",
         "promptfoo": "0.121.15",
         "xml-formatter": "3.7.0",
         "ts-node": "10.9.2",

packages/fiori-mcp-server/skills/sap-fiori-adp-project-setup/SKILL.md

@@ -0,0 +1,114 @@
+---
+name: sap-fiori-adp-project-setup
+author: sap-fiori-tools
+version: 0.0.1
+description: Use when creating a new SAP Fiori adaptation project, setting up an adaptation editor, or adapting an existing Fiori app on an SAP system
+---
+
+# ADP Project Setup
+
+End-to-end workflow for creating a SAP Fiori adaptation project and launching the adaptation editor.
+
+## Prerequisites
+
+- fiori-mcp server connected (provides `mcp__fiori-mcp__*` tools)
+- User knows which SAP system and application to adapt (or will be guided)
+
+### Installing fiori-mcp
+
+This skill requires the `@sap-ux/fiori-mcp-server` MCP server. It is part of the [SAP UX Tools](https://github.com/SAP/open-ux-tools) open-source project.
+
+**Install via npm:**
+
+```bash
+npm install -g @sap-ux/fiori-mcp-server
+```
+
+**Configure in your MCP client** (e.g. Claude Desktop `claude_desktop_config.json`, or VS Code `settings.json`):
+
+```json
+{
+  "mcpServers": {
+    "fiori-mcp": {
+      "command": "npx",
+      "args": ["-y", "@sap-ux/fiori-mcp-server"]
+    }
+  }
+}
+```
+
+After adding the server, restart your MCP client. The `mcp__fiori-mcp__*` tools should appear in the available tools list.
+
+## Workflow
+
+### Step 1: Discover Available Systems
+
+Call `mcp__fiori-mcp__list_sap_systems` to retrieve the list of configured SAP systems.
+
+Present the systems to the user. If no systems are found, inform the user they need to configure a system first (via SAP Fiori tools system store or BAS destinations).
+
+### Step 2: Gather Parameters
+
+Ask the user for:
+1. **System** — which SAP system to use (from the list)
+2. **Application** — the application ID to adapt (e.g., `sap.ui.demoapps.rta.fe`)
+3. **Target folder** — where to create the project (default: current working directory)
+4. **Project name** — optional, defaults to `app.variant`
+
+If the user does not know the application ID, suggest they check the Fiori Apps Library or their system's app index.
+
+### Step 3: Generate the Adaptation Project
+
+Call `mcp__fiori-mcp__generate_adaptation_project` with:
+- `system`: selected system name
+- `application`: the application ID
+- `appPath`: current working directory or user-specified path
+- `targetFolder`: where to generate (absolute path)
+- `projectName`: user's choice or default
+
+Optional parameters if user provides them: `namespace`, `applicationTitle`, `client`, `username`, `password`.
+
+Wait for completion. Report success or failure.
+
+### Step 4: Patch ui5.yaml for Local Proxy (DEMO ONLY)
+
+**Only if the user explicitly requests demo/local mode or mentions localhost proxy.**
+
+Read the generated `ui5.yaml` in the project root. In the `fiori-tools-proxy` middleware config, change:
+- `url` → `http://localhost:8080`
+- `version` → leave empty (remove the value)
+- Keep `path` as-is
+
+### Step 5: Launch the Adaptation Editor
+
+Call `mcp__fiori-mcp__open_adaptation_editor` with:
+- `appPath`: absolute path to the generated adaptation project root (where `package.json` resides)
+
+The tool returns:
+- `editorUrl` — full URL to open the adaptation editor
+- `processId` — background server PID
+- `port` — server port
+
+### Step 6: Report Success
+
+Present to the user:
+- Project location (absolute path)
+- Editor URL
+- Server PID and port (for cleanup)
+- Next step: "Use the `sap-fiori-adp-controller-extension-flow` skill to make RTA changes, or open the URL in your browser."
+
+## Error Handling
+
+- **No systems found:** User must configure systems first
+- **Generation fails:** Check credentials, application ID validity, system connectivity
+- **Editor launch fails:** Verify project path is correct and `package.json` exists
+- **ui5.yaml not found:** Skip patch, warn user
+
+## Cleanup
+
+The editor server runs in background. To stop it later:
+```bash
+kill <processId>
+# or by port:
+lsof -ti:<port> | xargs kill
+```

packages/fiori-mcp-server/src/constant.ts

@@ -2,6 +2,9 @@ export const LATEST_UI5_VERSION = '1.136.7';
 export const ADD_PAGE = 'add-page';
 export const DELETE_PAGE = 'delete-page';
 export const CREATE_CONTROLLER_EXTENSION_FUNCTIONALITY_ID = 'create-controller-extension';
+export const GENERATE_ADAPTATION_PROJECT_ID = 'generate-adaptation-project';
+export const ADP_CONTROLLER_EXTENSION_FUNCTIONALITY_ID = 'adp-controller-extension';
+export const OPEN_ADAPTATION_EDITOR_ID = 'open-adaptation-editor';
 export const EXTENSION_FILE_NAME_PATTERN = /^[A-Za-z][A-Za-z0-9_-]*$/;
 
 // Telemetry event names

packages/fiori-mcp-server/src/server.ts

@@ -20,8 +20,13 @@ import {
     downloadODataServiceMetadata,
     generateFioriAppOData,
     generateFioriAppCap,
+    generateAdaptationProject,
+    openAdaptationEditor,
+    adpControllerExtension,
+    runRtaWorkflowStep,
     tools
 } from './tools/index.js';
+import { stopBrowser } from './tools/run-rta-workflow-step/browser/index.js';
 import { TelemetryHelper, unknownTool, type TelemetryData } from './telemetry/index.js';
 import { TELEMETRY_MCP_SERVER_INITIALIZED, TELEMETRY_MCP_LIST_TOOLS } from './constant.js';
 import type {
@@ -30,7 +35,11 @@ import type {
     DocSearchInput,
     ListFioriAppsInput,
     ListFunctionalitiesInput,
-    DownloadODataServiceMetadataInput
+    DownloadODataServiceMetadataInput,
+    GenerateAdaptationProjectInput,
+    OpenAdaptationEditorInput,
+    AdpControllerExtensionInput,
+    RunRtaWorkflowStepInput
 } from './types/index.js';
 import type { GeneratorConfigOData, GeneratorConfigCAP } from './tools/schemas/index.js';
 import { logger } from './utils/logger.js';
@@ -44,6 +53,10 @@ type ToolArgs =
     | DownloadODataServiceMetadataInput
     | GeneratorConfigOData
     | GeneratorConfigCAP
+    | GenerateAdaptationProjectInput
+    | OpenAdaptationEditorInput
+    | AdpControllerExtensionInput
+    | RunRtaWorkflowStepInput
     | Record<string, unknown>;
 
 const FALLBACK_PROTOCOL_VERSION = '2024-11-05';
@@ -107,6 +120,7 @@ export class FioriFunctionalityServer {
     private setupErrorHandling(): void {
         this.server.onerror = (error): void => logger.error(`[MCP Error] ${error}`);
         process.on('SIGINT', async () => {
+            await stopBrowser();
             await this.server.close();
             process.exit(0);
         });
@@ -273,6 +287,18 @@ Never skip steps or guess functionalityIds. Never use a functionalityId as a too
                     case 'generate_fiori_app_cap':
                         result = await generateFioriAppCap(args as GeneratorConfigCAP);
                         break;
+                    case 'generate_adaptation_project':
+                        result = await generateAdaptationProject(args as GenerateAdaptationProjectInput);
+                        break;
+                    case 'open_adaptation_editor':
+                        result = await openAdaptationEditor(args as OpenAdaptationEditorInput);
+                        break;
+                    case 'adp_controller_extension':
+                        result = await adpControllerExtension(args as AdpControllerExtensionInput);
+                        break;
+                    case 'run_rta_workflow_step':
+                        result = await runRtaWorkflowStep(args as RunRtaWorkflowStepInput);
+                        break;
                     case 'list_functionality':
                         result = await listFunctionalities(args as ListFunctionalitiesInput);
                         break;
@@ -286,7 +312,7 @@ Never skip steps or guess functionalityIds. Never use a functionalityId as a too
                         // Do not pass telemetryProperties to unknownTool
                         await TelemetryHelper.sendTelemetry(unknownTool, {}, (args as any)?.appPath);
                         throw new Error(
-                            `Unknown tool: ${name}. Try one of: search_docs, list_fiori_apps, list_sap_systems, download_odata_service_metadata, generate_fiori_app_odata, generate_fiori_app_cap, list_functionality, get_functionality_details, execute_functionality.`
+                            `Unknown tool: ${name}. Try one of: search_docs, list_fiori_apps, list_sap_systems, download_odata_service_metadata, generate_fiori_app_odata, generate_fiori_app_cap, generate_adaptation_project, open_adaptation_editor, adp_controller_extension, run_rta_workflow_step, list_functionality, get_functionality_details, execute_functionality.`
                         );
                 }
                 await TelemetryHelper.sendTelemetry(name, telemetryProperties, (args as any)?.appPath);

packages/fiori-mcp-server/src/tools/adp-controller-extension/ai-response/index.ts

@@ -0,0 +1,3 @@
+export { extractFilesFromResponse, isChangeFile } from './parser.js';
+export { processAiResponse } from './processor.js';
+export { PathTraversalError, resolveWithinAppPath, writeExtractedFile } from './writer.js';

packages/fiori-mcp-server/src/tools/adp-controller-extension/ai-response/parser.ts

@@ -0,0 +1,79 @@
+import type { ExtractedFile } from '../types.js';
+import { logger } from '../../../utils/logger.js';
+
+const PATH_MARKER = /\*\*Path:\*\*\s*(.+)/;
+const FENCE_OPEN = /^```(\w+)?/;
+const FENCE_CLOSE = /^```\s*$/;
+
+function processOutsideBlock(
+    line: string,
+    state: { inCodeBlock: boolean; currentPath: string; currentCode: string }
+): void {
+    const pathMatch = PATH_MARKER.exec(line);
+    if (pathMatch) {
+        state.currentPath = pathMatch[1].trim();
+        return;
+    }
+    if (FENCE_OPEN.test(line)) {
+        state.inCodeBlock = true;
+        state.currentCode = '';
+    }
+}
+
+function processInsideBlock(
+    line: string,
+    state: { inCodeBlock: boolean; currentPath: string; currentCode: string },
+    codeBlocks: ExtractedFile[]
+): void {
+    if (FENCE_CLOSE.test(line)) {
+        state.inCodeBlock = false;
+        if (state.currentPath && state.currentCode.trim()) {
+            codeBlocks.push({ path: state.currentPath, code: state.currentCode.trim() });
+        }
+        state.currentPath = '';
+        state.currentCode = '';
+        return;
+    }
+    state.currentCode += line + '\n';
+}
+
+/**
+ * Parses an AI response containing markdown code blocks preceded by
+ * `**Path:** <fullFilePath>` markers and returns the extracted files. Lines
+ * outside fenced blocks are ignored. A code block without a preceding path
+ * marker is dropped.
+ *
+ * @param content Raw AI response text.
+ * @returns Files declared in the response.
+ */
+export function extractFilesFromResponse(content: string): ExtractedFile[] {
+    const codeBlocks: ExtractedFile[] = [];
+    const state = { inCodeBlock: false, currentPath: '', currentCode: '' };
+
+    for (const line of content.split('\n')) {
+        if (!state.inCodeBlock) {
+            processOutsideBlock(line, state);
+        } else {
+            processInsideBlock(line, state, codeBlocks);
+        }
+    }
+
+    if (state.inCodeBlock) {
+        logger.warn(
+            `AI response ended with an unclosed code block — content discarded for path: "${state.currentPath || '(no path)'}"`
+        );
+    }
+
+    return codeBlocks;
+}
+
+/**
+ * Returns `true` for `.change` files. The AI may emit those alongside code
+ * files but they are persisted by a separate flow, so the writer skips them.
+ *
+ * @param filePath Candidate file path or filename.
+ * @returns Whether the path looks like a flexibility change file.
+ */
+export function isChangeFile(filePath: string): boolean {
+    return filePath.toLowerCase().endsWith('.change');
+}