fix(test): replace fragile instance-identity check in EntityModelLoadTest#749
Open
ikalachy wants to merge 1 commit into
Open
fix(test): replace fragile instance-identity check in EntityModelLoadTest#749ikalachy wants to merge 1 commit into
ikalachy wants to merge 1 commit into
Conversation
…erTest The previous assertion relied on CdsModelReader's internal Caffeine weak-reference cache returning the same CdsModel instance for two separate readCsnModel calls on the same file. Under GC pressure on CI the weak reference is collected between the two calls, producing different instances and a spurious test failure. Replace with a structural assertion on the qualified names of services and entities, which is stable, meaningful, and independent of caching behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous assertion relied on CdsModelReader's internal Caffeine weak-reference cache returning the same CdsModel instance for two separate readCsnModel calls on the same file. Under GC pressure on CI the weak reference is collected between the two calls, producing different instances and a spurious test failure.
Replace with a structural assertion on the qualified names of services and entities, which is stable, meaningful, and independent of caching behaviour.