fix(kymabinding): surface BTP error bodies on Describe + Delete#735
Open
maximilianbraun wants to merge 4 commits into
Open
fix(kymabinding): surface BTP error bodies on Describe + Delete#735maximilianbraun wants to merge 4 commits into
maximilianbraun wants to merge 4 commits into
Conversation
DescribeInstance and DeleteInstances now route the API error through the existing specifyAPIError helper so the structured BTP error body lands in the resource's Synced condition instead of an opaque transport error. The deliberate 404 swallow in DeleteInstances is preserved.
maximilianbraun
temporarily deployed
to
pr-e2e-approval
GitHub Actions
Inactive
maximilianbraun
added
the
release-notes/bugfix
maximilianbraun
commented
Jun 20, 2026
maximilianbraun
left a comment
maximilianbraun
left a comment
Member
Author
There was a problem hiding this comment.
Lean. No over-engineering findings.
jn-av
had a problem deploying
to
pr-e2e-no-approval
GitHub Actions
Failure
jn-av
had a problem deploying
to
pr-e2e-no-approval
GitHub Actions
Failure
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
had a problem deploying
to
pr-e2e-no-approval
GitHub Actions
Failure
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
had a problem deploying
to
pr-e2e-no-approval
GitHub Actions
Failure
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
had a problem deploying
to
pr-e2e-no-approval
GitHub Actions
Failure
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DescribeInstanceandDeleteInstancesininternal/clients/kymaenvironmentbinding/binding.gonow route their API errors through the existing package-levelspecifyAPIErrorhelper (already used byCreateInstance). Previously the bare transport error was wrapped, so the structuredApiExceptionResponseObjectbody never reached the resource'sSyncedcondition.DeleteInstancesis preserved (covered by a regression test).DescribeInstance's wrap message waserrKymaBindingCreateFailed; introduceserrKymaBindingDescribeFailed.DeleteAPI5xxWrappedWithSpecifyAPIErrorpattern (PR fix(subaccount): surface BTP error bodies on delete via Synced condition #716).Part of the BTP error-body fan-out series.
Test plan
go build ./...go vet ./...go test -race -count=1 ./internal/clients/kymaenvironmentbinding/...go test -race -count=1 ./...— full suite greengofmt -l internal/clients/kymaenvironmentbinding/clean