fix(directory): surface BTP error bodies via specifyAPIError#731
Open
maximilianbraun wants to merge 3 commits into
Open
fix(directory): surface BTP error bodies via specifyAPIError#731maximilianbraun wants to merge 3 commits into
maximilianbraun wants to merge 3 commits into
Conversation
maximilianbraun
added
the
release-notes/bugfix
maximilianbraun
requested a deployment
to
pr-e2e-approval
GitHub Actions
Waiting
maximilianbraun
commented
Jun 20, 2026
maximilianbraun
left a comment
maximilianbraun
left a comment
Member
Author
There was a problem hiding this comment.
internal/clients/directory/directory_test.go:880 — Drop the local create409Error; it is a verbatim copy of subaccount_test.go's helper (same unsafe-pointer reflection over GenericOpenAPIError's unexported fields). Move one copy to internal/testutils (or wherever the BTP test helpers live) and import it from both packages — duplicating a reflect/unsafe trick guarantees one of them rots silently when the SDK regenerates.
maximilianbraun
requested a deployment
to
pr-e2e-approval
GitHub Actions
Waiting
maximilianbraun
commented
Jun 20, 2026
maximilianbraun
left a comment
maximilianbraun
left a comment
Member
Author
There was a problem hiding this comment.
Helper is appropriately minimal: every parameter has a caller using it, the empty-message branch lets the original code-only call site stay one-liner, and the regeneration-rot warning is the right ceiling note for unsafe-reflection. Subaccount_test.go edit is the deduplication itself, not scope creep. Lean.
3 tasks
maximilianbraun
added a commit
that referenced
this pull request
Jun 20, 2026
Reviewer flagged 4 inline reflect+unsafe copies that all set the unexported `body` field on a *xsuaa.GenericOpenAPIError. Extract to internal/testutils/openapi_errors_xsuaa.go::NewXsuaaAPIError so each test site collapses to one line. Filed under a separate filename from PR #731's openapi_errors.go to avoid a rebase collision; the two helpers can be unified once both branches land.
maximilianbraun
requested a deployment
to
pr-e2e-approval
GitHub Actions
Waiting
maximilianbraun
force-pushed
the
fix/directory-surface-btp-error-bodies
branch
from
939efc9 to
51e8cde
Compare
maximilianbraun
requested a deployment
to
pr-e2e-approval
GitHub Actions
Waiting
jn-av
had a problem deploying
to
pr-e2e-no-approval
GitHub Actions
Failure
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
had a problem deploying
to
pr-e2e-no-approval
GitHub Actions
Failure
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
had a problem deploying
to
pr-e2e-no-approval
GitHub Actions
Failure
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
had a problem deploying
to
pr-e2e-no-approval
GitHub Actions
Failure
maximilianbraun
had a problem deploying
to
pr-e2e-no-approval
GitHub Actions
Failure
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
had a problem deploying
to
pr-e2e-no-approval
GitHub Actions
Failure
maximilianbraun
had a problem deploying
to
pr-e2e-no-approval
GitHub Actions
Failure
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
maximilianbraun
temporarily deployed
to
pr-e2e-no-approval
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeleteDirectoryandUpdateDirectorynon-404 paths through the existingspecifyAPIErrorhelper so 409/5xx BTP error bodies surface in theSyncedcondition instead of bare transport errors.Test plan
go build ./... && go vet ./...go test -race -count=1 ./internal/clients/directory/... ./internal/controller/account/directory/...DeleteAPI409SurfacesErrorunit test exercising aGenericOpenAPIErrorwithApiExceptionResponseObjectmodel.