Skip to content

fix(auditlog_ng): add tenant to auditlog destination resolution#189

Merged
betinacosta merged 17 commits into
mainfrom
bugfix/add-tenant-to-auditlog-destination-resolution
Jun 25, 2026
Merged

fix(auditlog_ng): add tenant to auditlog destination resolution#189
betinacosta merged 17 commits into
mainfrom
bugfix/add-tenant-to-auditlog-destination-resolution

Conversation

@betinacosta

Copy link
Copy Markdown
Member

Description

This PR corrects an issue where the tenant parameter was not included in destination resolution, causing incorrect destination lookups in multi-tenant setups.

Related Issue

Closes #

(Link to the GitHub issue this PR addresses)

Type of Change

Please check the relevant option:

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Dependency update

How to Test

Call create_client() with tenant:

from sap_cloud_sdk.core.auditlog_ng import create_client

client = create_client(
    tenant="my-tenant-subdomain",
)

Checklist

Before submitting your PR, please review and check the following:

  • I have read the Contributing Guidelines
  • I have verified that my changes solve the issue
  • I have added/updated automated tests to cover my changes
  • All tests pass locally
  • I have verified that my code follows the Code Guidelines
  • I have updated documentation (if applicable)
  • I have added type hints for all public APIs
  • My code does not contain sensitive information (credentials, tokens, etc.)
  • I have followed Conventional Commits for commit messages

@betinacosta betinacosta requested a review from a team as a code owner June 25, 2026 19:10
Comment thread src/sap_cloud_sdk/core/auditlog_ng/__init__.py
@betinacosta betinacosta merged commit 5249611 into main Jun 25, 2026
11 checks passed
@betinacosta betinacosta deleted the bugfix/add-tenant-to-auditlog-destination-resolution branch June 25, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants