Quickstart2.0#996
Draft
abhissharma21 wants to merge 21 commits into
Draft
Conversation
abhissharma21
requested review from
cernus76,
jmsrpp,
julian-schambeck and
navyakhurana
as code owners
Fix delta sync for editor operations and improve UX
Delta Sync Fixes:
- Add comprehensive operation logging for all node types (tables,
lists, headings, quotes, admonitions, paragraphs)
- Log INSERT_NODE for all nested nodes in tables (rows, cells, text)
- Log operations for table row/column add, insert, and delete
- Log operations for list item creation and list removal
- Log operations for block type conversions and duplications
- Log operations for block moves and text formatting changes
- Add clearOperations() method to EditorCore
- Add validation in pageDataStore to fall back to full sync if
appliedCount is 0
- Fix race condition between full sync and delta sync with proper
timing and flags
Bug Fixes:
- Fix backspace on empty heading/quote causing editor to freeze
(children were deleted by removeNode before being re-added)
UX Improvements:
- Add auto-scroll when dragging blocks near viewport edges
- Add dark mode active state styling for toolbar buttons
cernus76
requested changes
May 7, 2026
Contributor
There was a problem hiding this comment.
I've tested and found a couple of issues:
-
The added contributors should have a warning that the document is not editable and the editor should be disabled.
-
The non active documents are not visible or not readable with the dark theme. True for Main or sub documents.
-
Sometimes the user cannot type anything anymore, like if it is locked for some reasons.
-
When a contributor is removed, the contributor still has access to the document (still visible).
-
Drag and drop of the text is not perfect in positioning before or after the text. It is not precise or incorrect.
-
drawio files are not loading anymore if we leave the page.
-
format of the drawio file does not display the file entirely. It seems truncated.
-
Added contributor is not persistent. A refresh and the contributor is gone.
Many issues when using the / command.
- I can see trailing
/after the headings H1, H2 and H3. - Headings cannot be deleted.
- Headings seem linked or in sync with some other headings. Deleting one delete the other one.
- Headings look different even if they use the me H2 for example. Refresh fixes it.
Contributor
|
Adding few problems to the
|
Contributor
|
As you can probably tell, PO and I did a longer testing round 😅
|
- Shift heading levels: H1→H2, H2→H3 internally (page title is H1) - Remove H3 option from slash commands and floating toolbar - Update TOC indentation to match shifted heading levels - Add animated folder loading placeholder for images/drawio - Add LetterGlitchLoader for QuickStart initialization screen - Fix MetaFormDialog to show Edit/Save when editing existing docs - Include description and contributors in edit mode - Remove edit button from ContributorsDisplay (click to edit) - Optimize sync: only call setDocumentContributors/Tags when changed - Add UPDATE_IMAGE/UPDATE_DRAWIO commands for async asset loading
1. Dark mode fixes for editor, toolbar, dialogs, dropdowns, and breadcrumbs 2. SAP UI5 BusyIndicator for image/drawio loading states 3. Paste handling - paragraph preservation and list detection 4. Human-readable timestamp format (DD/MM/YYYY, HH:MM:SS) 5. Fixed editor locking (isRendering flag stuck) 6. Fixed unsynced block indicator (::before → ::after) 7. Fixed contributor sync for empty arrays 8. Fixed Drawio memory leak (blob URL cleanup) 9. Fixed media placeholder → content transition in DOMReconciler
- Add zoom in/out, fit, and edit buttons for drawio diagrams - Create DrawioEditorPlugin for inline diagram editing - Replace timestamp with Saving.../Saved status indicator - Add colored status dots (yellow=saving, green=saved, red=error) - Fix auth card dark mode styling for architecture validator - Fix media placeholder to content transition in DOMReconciler - Extract addDrawioToolbar helper method for reusability
…w render at correct size, scale to fit container width, and iframe height auto-adjusts to content.
- Add My Documents and Shared with me sections in sidebar - Show View Only banner for contributor documents - Fix dark/light mode flickering in Safari with early theme init - Fix React unmount race condition in MediaLoadingPlugin - Auto-redirect unauthenticated users to GitHub login - Rewrite toolbar with icons and organized dropdowns (Insert, Callout) - Add Heading 1 as disabled (reserved for title) in toolbar and slash menu - Prevent nesting admonitions, images, diagrams, and tables inside callouts - Fix yellow sync indicator appearing next to links instead of block start - Fix link preview not closing on selection change - Change date format to Mon DD, YYYY in article header - Default document selection prioritizes owned documents over shared
|
Issue found: After submitting Quick Start and navigating to the Lexical Editor page, tags such as "Integration" and "Data Analytics" show a pointer cursor on hover, making them appear clickable, but clicking them has no effect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quickstart 2.0