chore: [DevOps] Add release environment#918
Open
Jonas-Isr wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
https://github.com/SAP/ai-sdk-java-backlog/issues/399
This is a left-over of the security hardening topic. The idea is to hide release-critical secrets in a specified environment. Then, any workflow that uses these secrets has to fulfil certain requirements. This is to make sure that no workflow that e.g. runs from a branch can simply use our critical secrets.
I set up an environment
releasein this repo (see link above) and added the secretsCENTRAL_SONATYPE_SETTINGS_XML,PGP_PASSPHRASE, andPGP_PRIVATE_KEY. I added the protection rule that any workflow that runs and wants to use these secrets needs to be manually approved by a member of our team.If we want this feature, we afterwards would need to delete the above three secrets from the list of repository secrets.
How it looks
Link to successful dummy run.
Feature scope:
Definition of Done
Tests cover the scope aboveError handling created / updated & covered by the tests aboveAligned changes with the JavaScript SDKDocumentation updatedRelease notes updated