[AIFS] Add new object type AIFS#788
Conversation
![hyperspace-insights[bot]](https://avatars.githubusercontent.com/u/2531208?s=60&v=4){kind=small}
There was a problem hiding this comment.
The PR adds the new AIFS (Structure Mapping) object type and is largely well-structured, but has several issues that must be fixed: the example file has a critical naming error (comma instead of period in the filename), is missing the required trailing newline, the ty_error_handling_type enum has an invalid $default configuration (the non-default constant holds the initial ABAP value, violating all three default-value rules), the co_check_ba constants use an inline type instead of the declared ty_check_ba alias, the README table is missing the example link, the ABAP field conversion_dataelement should be conversion_data_element, and the shorttext "Mapping Informations" uses an incorrect plural form.
PR Bot Information
Version: 1.22.8
- Review Focus Files:
- LLM:
anthropic--claude-4.6-sonnet - File Content Strategy: Full file content
- Agent Instructions:
- Event Trigger:
issue_comment.created - Correlation ID:
9411072d-af83-406f-96ef-14c5a2eb9ec6
Markus1812
left a comment
Markus1812
left a comment
There was a problem hiding this comment.
Hi, thanks for the contribution. Please see my comments below (and also from the hyperspace-bot). As this is a very large AFF, we might need multiple review-iterations, as it is quite hard to oversee everything on first sight.
| "! <p class="shorttext">Namespace</p> | ||
| "! Namespace of the structure mapping | ||
| "! $required | ||
| namespace TYPE c LENGTH 15, |
There was a problem hiding this comment.
This is the AIF Namespace (AIFN), right?
| "! <p class="shorttext">Number</p> | ||
| "! Number | ||
| "! $required | ||
| number TYPE n LENGTH 3, |
There was a problem hiding this comment.
In all lists, there is a number, numericId or fieldNumber. Do you really need these? In the JSON (and in the server-driven UI) the order of items is always the order in which the user added the items (or rearranges them). As a user, I would prefer not to enter a sequential number for each entry I add to a list. What happens if I remove the first entry? Do I have to change all numbers?
There was a problem hiding this comment.
Hi Markus.
The numericID isn't actually about sequence order. For Structure Mapping and Field Mapping, the execution order is based on the JSON array order (managed by separate fields not in the AFF).
Fields like number and fieldNumber are explicit IDs used by other objects, and users need them to connect corresponding records across those objects. Unfortunately, this means we must keep all of these IDs in the schema.
However, to solve the UX issue you mentioned, we will auto-generate these numeric IDs for internal records within the Structure Mapping object and make them strictly read-only in the UI.
3 participants
No description provided.