Tidy up file structure and naming conventions - #105
Merged
Merged
Conversation
thompson318
had a problem deploying
to
hasher
September 16, 2026 13:51 — with
GitHub Actions
Failure
thompson318
had a problem deploying
to
hasher
September 16, 2026 13:59 — with
GitHub Actions
Failure
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ehr_queries_clean #105 +/- ##
=====================================================
- Coverage 74.71% 74.68% -0.03%
=====================================================
Files 18 18
Lines 870 869 -1
Branches 79 79
=====================================================
- Hits 650 649 -1
Misses 193 193
Partials 27 27 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses some of the file naming issues identified in #103.
Replaces underscore with . see : #103 (comment)
Places the ehr files in the same directory as the waveform data
pseudonymised\{date}\{stem}.ehr.csvto address #103 (comment).I haven't been able to to setup
get_ehr_lookupas the single source of truth yet and am unlikely to be able to get to have time this week.The file names will need changing to
pseudonymised\{date}\{stem}.ehr.parquetin a separate change.Feel free to merge this if and when convenient.
The linting error occurs on code which the same as the target branch where linting is currently skipped, so I've left it alone for now.