Skip to content

Tidy up file structure and naming conventions - #105

Merged
jeremyestein merged 3 commits into
ehr_queries_cleanfrom
st/get_ehr
Sep 17, 2026
Merged

jeremyestein merged 3 commits into
ehr_queries_cleanfrom
st/get_ehr

Conversation

@thompson318

@thompson318 thompson318 commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

This addresses some of the file naming issues identified in #103.

Replaces underscore with . see : #103 (comment)

Places the ehr files in the same directory as the waveform data pseudonymised\{date}\{stem}.ehr.csv to address #103 (comment).

I haven't been able to to setup get_ehr_lookup as the single source of truth yet and am unlikely to be able to get to have time this week.

The file names will need changing to pseudonymised\{date}\{stem}.ehr.parquet in a separate change.

Feel free to merge this if and when convenient.

The linting error occurs on code which the same as the target branch where linting is currently skipped, so I've left it alone for now.

@codecov

codecov Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.68%. Comparing base (f6944e1) to head (56a1ac6).

Additional details and impacted files
@@                  Coverage Diff                  @@
##           ehr_queries_clean     #105      +/-   ##
=====================================================
- Coverage              74.71%   74.68%   -0.03%     
=====================================================
  Files                     18       18              
  Lines                    870      869       -1     
  Branches                  79       79              
=====================================================
- Hits                     650      649       -1     
  Misses                   193      193              
  Partials                  27       27              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jeremyestein
jeremyestein merged commit ea3ea7d into ehr_queries_clean Sep 17, 2026
3 of 4 checks passed
@jeremyestein
jeremyestein deleted the st/get_ehr branch September 17, 2026 14:08

This branch was successfully deployed

1 active deployment
hasher 56a1ac66 Deployed Sep 16, 2026 by thompson318 via Run pytest #206
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants