Skip to content

Split the diff_errors logic from DicomValidator.validate_anonymised into a separate function - #676

Merged
p-j-smith merged 2 commits into
paul/665-dicom-validator-0.9from
paul/665-get-new-errors
Sep 17, 2026
Merged

p-j-smith merged 2 commits into
paul/665-dicom-validator-0.9from
paul/665-get-new-errors

Conversation

@p-j-smith

@p-j-smith p-j-smith commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Description

Part of #665
Closes PIX-78

  • not necessary, but I thought it would make sense to create a new function get_new_errors that contains the logic for comparing validation errors from the original and anonymised datasets
  • update tests to use the get_new_errors function

Type of change

Please delete options accordingly to the description.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Suggested Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have passed on my local host device. (see further details at the CONTRIBUTING document)
  • Make sure your branch is up-to-date with main branch. See CONTRIBUTING for a general example to syncronise your branch with the main branch.
  • I have requested review to this PR.
  • I have addressed and marked as resolved all the review comments in my PR.
  • Finally, I have selected squash and merge

@p-j-smith
p-j-smith added this pull request to stack #672 September 17, 2026 08:52
@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.41%. Comparing base (d7dec18) to head (da38785).

Additional details and impacted files
@@                       Coverage Diff                        @@
##           paul/665-dicom-validator-0.9     #676      +/-   ##
================================================================
+ Coverage                         88.40%   88.41%   +0.01%     
================================================================
  Files                                81       81              
  Lines                              3966     3972       +6     
================================================================
+ Hits                               3506     3512       +6     
  Misses                              460      460              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@linear-code

linear-code Bot commented Sep 17, 2026

Copy link
Copy Markdown

PIX-78

@p-j-smith
p-j-smith force-pushed the paul/665-get-new-errors branch from c6edbf4 to f0d8354 Compare September 17, 2026 14:17
@p-j-smith
p-j-smith force-pushed the paul/665-get-new-errors branch from f0d8354 to da38785 Compare September 17, 2026 14:31
@p-j-smith
p-j-smith merged commit 5dd5114 into main Sep 17, 2026
11 checks passed
@p-j-smith
p-j-smith deleted the paul/665-get-new-errors branch September 17, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants