Update pydicom to version 3 - #671
Merged
Merged
Conversation
p-j-smith
added this pull request to stack #672
September 17, 2026 07:31
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## paul/665-uv-lock-format #671 +/- ##
============================================================
+ Coverage 67.31% 88.37% +21.05%
============================================================
Files 56 81 +25
Lines 2408 3956 +1548
============================================================
+ Hits 1621 3496 +1875
+ Misses 787 460 -327 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
p-j-smith
force-pushed
the
paul/665-pydicom-3
branch
from
September 17, 2026 09:00
75b23e6 to
5557dc3
Compare
stefpiatek
approved these changes
Sep 17, 2026
p-j-smith
force-pushed
the
paul/665-pydicom-3
branch
from
September 17, 2026 14:17
5557dc3 to
d187df4
Compare
We also need to update to: deid 0.4.12 dicom-anonymizer 2.0.0 Update uv.lock
write_like_original=False to ds.save_as is deprecated use enforce_file_format=True instead don't set ds.is_implicit_VR and ds.is_little_endian attributes they are not dicom tags, but pydicom dataset attributes, and are no longer used in pydicom 3 instead, pass implicit_vr=True, little_endian=True to ds.save_as
p-j-smith
force-pushed
the
paul/665-pydicom-3
branch
from
September 17, 2026 14:31
d187df4 to
8c4fc61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of #665
pydicom==3.0.2. This also means when need to update the versions ofdeidanddicom-analyzerwrite_like_original=Falsehas been removed inpydicom3. Useenforce_file_format=Trueinsteadimplicit_vr=Trueandlittle_endian=Trueas arguments when saving aDataset, rather than setting them as attributespixel_datanp.uint16to correspond to theBitsAllocated=16tag we set when generating the test dataset, otherwisepydicom3 raises a warning, which would maketest_anonymise_and_validate_dicomfail as we check there are no warnings in the logsType of change
Please delete options accordingly to the description.
Suggested Checklist
mainbranch.squash and merge