Skip to content

Fix missing workspace lints & fix lints - #8781

Draft
joshuamegnauth54 wants to merge 1 commit into
RustPython:mainfrom
joshuamegnauth54:deprecated-constants
Draft

joshuamegnauth54 wants to merge 1 commit into
RustPython:mainfrom
joshuamegnauth54:deprecated-constants

Conversation

@joshuamegnauth54

@joshuamegnauth54 joshuamegnauth54 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Some of the workspace packages were missing the [lints] table. I enabled the lints then fixed the resulting errors.

  • Closes #xxxx

One of checkbox below must be checked.

  • I did not use AI to write the code of this patch.
  • This PR follows our AI policy

Summary

  • Add missing [lints] table to a few Cargo.toml.
  • Fix lints that arose from those lints being enabled.

Summary by CodeRabbit

  • Chores

    • Standardized lint configuration across additional components.
    • Aligned selected dependency versions with workspace settings.
  • Refactor

    • Restricted access to internal utilities and helper APIs to their intended scopes.
    • Simplified internal constant usage and removed an unused import.
    • Updated an internal data structure layout for C-compatible alignment.
  • Behavior

    • No user-facing functionality or runtime behavior changes.

Some of the workspace packages were missing the `[lints]` table. I
enabled the lints then fixed the resulting errors.
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: RustPython/RustPython/.coderabbit.yml

Review profile: CHILL

Plan: Advanced

Run ID: ab866e2f-956d-411d-ba29-9481043d8be9

📥 Commits

Reviewing files that changed from the base of the PR and between fe45a7a and 50222f7.

📒 Files selected for processing (11)
  • Cargo.toml
  • crates/common/src/float_ops.rs
  • crates/host_env/Cargo.toml
  • crates/literal/Cargo.toml
  • crates/literal/src/float.rs
  • crates/stdlib/src/hashlib.rs
  • crates/wtf8/Cargo.toml
  • crates/wtf8/src/concat.rs
  • crates/wtf8/src/core_char.rs
  • crates/wtf8/src/core_str.rs
  • src/shell/helper.rs
💤 Files with no reviewable changes (2)
  • crates/stdlib/src/hashlib.rs
  • crates/literal/src/float.rs

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The pull request enables workspace lint inheritance, centralizes selected dependency versions, narrows internal Rust visibility, updates hash state representations, and removes or simplifies unused imports.

Changes

Rust workspace and API cleanup

Layer / File(s) Summary
Workspace lint and dependency declarations
Cargo.toml, crates/literal/Cargo.toml, crates/wtf8/Cargo.toml, crates/host_env/Cargo.toml
The root package and two crates inherit workspace lints. Selected host_env dependencies now use workspace-managed versions.
Internal API visibility boundaries
crates/wtf8/src/concat.rs, crates/wtf8/src/core_char.rs, crates/wtf8/src/core_str.rs, src/shell/helper.rs
WTF-8 helpers and ShellHelper APIs are restricted to crate or parent-module scope. The completion context uses an explicit lifetime.
Source declarations and layout cleanup
crates/common/src/float_ops.rs, crates/literal/src/float.rs, crates/stdlib/src/hashlib.rs
LOG10_2 uses a direct import, an unused import is removed, and two hash state structs use C layout with 16-byte alignment.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: shaharnaveh, youknowone

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 5 files. (4 skipped: 4… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: enabling missing workspace lint configurations and fixing the lint issues they reveal.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 5 files. (4 skipped: 4 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@joshuamegnauth54
joshuamegnauth54 marked this pull request as draft September 22, 2026 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant