Change separator from ; to ,#162
Closed
sfraczek wants to merge 4 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CSV parser to use comma (,) as the delimiter instead of semicolon (;) for Revolut data files. Since dates in the CSV contain commas, the change requires proper handling of quoted fields.
- Changed delimiter from
;to,throughout the parser - Added
csv_record_to_linehelper function to properly handle quoted CSV fields - Updated CSV reader configuration to use the new delimiter
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The separator is not
;in revolut_data, but,. Using,as separator doesn't work because the date contains commas. A proper parsing of quoted strings is needed to use separator,.