build: generate fvsOL's prms + help data artifacts (fix keyword-edito…#24
Merged
Conversation
…r crash)
fvsOL's makefile generates two data objects from source and gitignores them:
data/prms.RData (the keyword-parameter catalog) and data/fvsOnlineHelpRender.RData
(in-app help). Our build runs roxygenize + install but NOT the makefile's
generation step, so both were missing from the WebGUI image. At runtime
`data(prms)` fails ("data set 'prms' not found") and the GUI's keyword-component
editor + help break. Basic runs/exports are unaffected, which is why it shipped
unnoticed (and why only a GUI click-through surfaced it).
This is a fvs-containers build gap, not an upstream fvsOL bug (the makefile
generates these correctly) and is unrelated to the RSQLite/encoding patches.
Fix: generate both artifacts before installing fvsOL, in both build paths:
- docker/Dockerfile (webgui target): Rscript parms/mkpkeys.R + inst/extdata/mkhelp.R
- .devcontainer/postCreate.sh: same, via R source() with renv active
Regression guard: smoke_test.R gains an fvsOL/data-artifacts check that asserts
prms, fvsOnlineHelpRender, and treeforms all load (fvsOnlineHelpRender.RData
loads as object `fvshelp`, so it checks each dataset loads *something*, not a
fixed name). smoke_test.R gates both ci.yaml and publish.yaml, so a build that
drops the generation step now goes red. Validated: guard FALSE without the
artifacts, TRUE with them.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…hadolint DL3003)
The webgui data-artifact generation step used `RUN cd /src/fvs-interface/fvsOL
&& ...`, which trips hadolint DL3003 ("Use WORKDIR to switch to a directory") and
fails the blocking pre-commit lint gate. Switch to WORKDIR (the repo's convention;
.hadolint.yaml deliberately doesn't ignore DL3003). The relative mkpkeys.R/mkhelp.R
paths still resolve, the roxygenize/install uses absolute paths, and the existing
`WORKDIR /work` below resets cwd for runtime -- no behavior change.
https://claude.ai/code/session_011C6wxKosiwHnEYvAPJfmcW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…r crash)
fvsOL's makefile generates two data objects from source and gitignores them: data/prms.RData (the keyword-parameter catalog) and data/fvsOnlineHelpRender.RData (in-app help). Our build runs roxygenize + install but NOT the makefile's generation step, so both were missing from the WebGUI image. At runtime
data(prms)fails ("data set 'prms' not found") and the GUI's keyword-component editor + help break. Basic runs/exports are unaffected, which is why it shipped unnoticed (and why only a GUI click-through surfaced it).This is a fvs-containers build gap, not an upstream fvsOL bug (the makefile generates these correctly) and is unrelated to the RSQLite/encoding patches.
Fix: generate both artifacts before installing fvsOL, in both build paths:
Regression guard: smoke_test.R gains an fvsOL/data-artifacts check that asserts prms, fvsOnlineHelpRender, and treeforms all load (fvsOnlineHelpRender.RData loads as object
fvshelp, so it checks each dataset loads something, not a fixed name). smoke_test.R gates both ci.yaml and publish.yaml, so a build that drops the generation step now goes red. Validated: guard FALSE without the artifacts, TRUE with them.What & why
Checklist
tests/unitortests/integration), or N/A.data/README.md).