[Improve] Auto singles out no kind of action: remove the money question - #3364
Merged
Merged
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Auto decides whether a tool call needs a person from what the session owner asked for. One built-in question broke that pattern: a call that moves money always asked, even when the owner requested it. That is a product opinion about one kind of action, fixed in code for every deployment. Deployments differ in what they treat as sensitive, and the guidance field already exists to say so.
What changes
movesMoneyquestion and its condition are removed from Auto. A payment now follows the same rule as any other action: it runs when the owner asked for it, agreed to a plan that describes it, or approved an earlier call it continues, and it asks otherwise.Screenshots
A requested payment runs with no card (empty guidance)
With "Anything that moves money needs a person to approve it." in guidance, the same request asks
The guidance field's placeholder
Testing
Labels were written before any run. Each case ran against the decision model several times, on this branch and on develop.
The benchmark's drop in needless asks comes from its money cases, which were relabelled to "run" because each is an action the owner asked for. Every other family scored the same on both sides.
New money cases under the generic rule (18 cases x10):
Live on a local stack against a mock integration: with empty guidance a requested payment ran with no card; with the money line in guidance the same request showed a card.
How to test
Known limits