Repository navigation
[Fix] Chat replies list every linked pull request - #3363
Draft
roomote-roomote[bot] wants to merge 1 commit into
Draft
roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
![roomote-community[bot]](https://avatars.githubusercontent.com/u/211522643?s=60&v=4){kind=small}
| if (prLinks.length > 0) items.push(prLinks.join(', ')); | ||
| const prs = linkedPrs ?? []; | ||
| const prLinks = prs | ||
| .slice(0, MAX_INLINE_THREAD_REPLY_PRS) |
Contributor
There was a problem hiding this comment.
The footer refresh path preserves PRs that have not yet been linked in the database by parsing every visible PR URL from the previous footer (mergeCarriedPullRequests). After this slice, a refresh can recover only the first three URLs; any fourth-or-later out-of-band PR is no longer in context.linkedPrs or the carried set, so the next refresh drops it and its N more PRs count. Preserve the omitted PR references somewhere refresh can rehydrate them, or avoid truncating the state-bearing footer representation.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
A Session can collect active pull requests from many attached tasks, causing every reply footer to repeat a long list of links. The footer should stay useful without turning ordinary replies into an unbounded status index.
Impact
Users still get direct access to the first three linked pull requests and can open the full Session in Roomote, while conversations with many linked pull requests remain compact. Sessions with three or fewer linked pull requests are unchanged.