refactor(fuselage): rewrite AutoComplete with derived selection state#2025
Draft
ggazzo wants to merge 1 commit into
Draft
refactor(fuselage): rewrite AutoComplete with derived selection state#2025ggazzo wants to merge 1 commit into
ggazzo wants to merge 1 commit into
Conversation
Replace duplicated local selection state with a value-derived useMemo, eliminating drift between value/options and the rendered chips. Extract keyboard navigation into a dedicated event.key-based hook scoped to AutoComplete, leaving the shared useCursor untouched. Same visual and public API; snapshots unchanged.
🦋 Changeset detectedLatest commit: 8bf2b46 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Current
AutoCompletekeeps a localselectedstate duplicated from the controlledvalueand syncs it viauseEffect. The sync only filters out now-invalid selections — it never re-adds newly-valid ones — soselecteddrifts fromvalue/options. Selection logic also writes bothsetSelectedandonChange, doubling bookkeeping.What
selectedis nowuseMemo(() => getSelected(value, options)). Single source of truth, drift bug gone, no sync effect.Array.isArray(value) ? value : [](wasvalue || [], which spreads a string into chars).useAutoCompleteCursor(scoped to AutoComplete) usingevent.keyinstead of deprecatedkeyCode, returning a named object instead of a 5-tuple. The shareduseCursor(used by Menu/Select/MultiSelect) is left untouched.Compatibility