Skip to content

chore: using setup_ci for ios build#6577

Merged
diegolmello merged 3 commits into
developfrom
fix-ci-setup
Aug 19, 2025
Merged

chore: using setup_ci for ios build#6577
diegolmello merged 3 commits into
developfrom
fix-ci-setup

Conversation

@Rohit3523

@Rohit3523 Rohit3523 commented Aug 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Proposed changes

During the migration from CircleCI to GitHub Actions in #6447, I forgot to change setup_circle_ci to setup_ci, which is more suitable and recommended by fastlane for GitHub Actions. The previous setup was causing the iOS build to hang on Signing NotificationService.appex, which resulted in the build failing. Hopefully, this change will fix the hanging issue.

Working Actions

Run 1
Run 2
Run 3
Run 4

Issue(s)

N/A

How to test or reproduce

N/A

Screenshots

N/A

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

N/A

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

This will break the iOS builds on Circle CI

@Rohit3523

Rohit3523 commented Aug 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Maybe it not stuck at Signing NotificationService.appex for iOS but merging this will break the Circle CI

@Rohit3523 Rohit3523 had a problem deploying to experimental_android_build August 19, 2025 09:13 — with GitHub Actions Error
@Rohit3523 Rohit3523 temporarily deployed to official_ios_build August 19, 2025 09:13 — with GitHub Actions Inactive
@Rohit3523 Rohit3523 temporarily deployed to experimental_ios_build August 19, 2025 09:13 — with GitHub Actions Inactive
@Rohit3523 Rohit3523 had a problem deploying to official_android_build August 19, 2025 09:13 — with GitHub Actions Error
@github-actions

github-actions Bot commented Aug 19, 2025

Copy link
Copy Markdown

iOS Build Available

Rocket.Chat Experimental 4.64.0.107010

@Rohit3523 Rohit3523 temporarily deployed to experimental_android_build August 19, 2025 10:51 — with GitHub Actions Inactive
@Rohit3523 Rohit3523 temporarily deployed to experimental_ios_build August 19, 2025 10:51 — with GitHub Actions Inactive
@Rohit3523 Rohit3523 temporarily deployed to official_ios_build August 19, 2025 10:51 — with GitHub Actions Inactive
@Rohit3523 Rohit3523 temporarily deployed to official_android_build August 19, 2025 10:51 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented Aug 19, 2025

Copy link
Copy Markdown

iOS Build Available

Rocket.Chat Experimental 4.64.0.107011

@Rohit3523 Rohit3523 had a problem deploying to upload_experimental_android August 19, 2025 11:30 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to upload_official_android August 19, 2025 11:31 — with GitHub Actions Error
@github-actions

github-actions Bot commented Aug 19, 2025

Copy link
Copy Markdown

Android Build Available

Rocket.Chat Experimental 4.64.0.107008

Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNSGaew1C--DJuExKV-2zLWChCUmjp_SAtEFfXxCO2TFq_v1Pte0FZeKzBHwb1JftvLGWU2PIGlL7Bzg6WS6

@github-actions

github-actions Bot commented Aug 19, 2025

Copy link
Copy Markdown

Android Build Available

Rocket.Chat 4.64.0.107007

Internal App Sharing: https://play.google.com/apps/test/RQQ8k09hlnQ/ahAO29uNSb-pCNMlShWO7NpI9aamJAVxIDiu7sPiz60rdG10KnwG58bph09Lx8aEtxySyzdCLhWudFX6JsvFPDIAv_

@github-actions

github-actions Bot commented Aug 19, 2025

Copy link
Copy Markdown

iOS Build Available

Rocket.Chat Experimental 4.64.0.107012

@github-actions

github-actions Bot commented Aug 19, 2025

Copy link
Copy Markdown

Android Build Available

Rocket.Chat 4.64.0.107007

Internal App Sharing: https://play.google.com/apps/test/RQQ8k09hlnQ/ahAO29uNSuCTNlLce8ITyLuywIp8_c11lC5QAuUjJyZvwe1dPaIcCe8R6AP3iAxCW3Vow65Rpvr7nUgf88QqqsDkgi

@github-actions

github-actions Bot commented Aug 19, 2025

Copy link
Copy Markdown

Android Build Available

Rocket.Chat Experimental 4.64.0.107008

Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNT4zjfwHJvSZdzP962C0jJYVlhf1MgRM1gHsVQDBQ0zrU2r_LcYUwMvrOZOYcL5TA48mRgsxCz1k2GZENOB

@github-actions

github-actions Bot commented Aug 19, 2025

Copy link
Copy Markdown

iOS Build Available

Rocket.Chat Experimental 4.64.0.107013

@github-actions

github-actions Bot commented Aug 19, 2025

Copy link
Copy Markdown

Android Build Available

Rocket.Chat 4.64.0.107007

Internal App Sharing: https://play.google.com/apps/test/RQQ8k09hlnQ/ahAO29uNTOixaGkRMWB_vtuTMbc8enYFprYFAZNqusms3wQi1XK33SN90Aq1CuwQO4zAS4B1TUTrRs4KBtFL7wCZm-

@github-actions

github-actions Bot commented Aug 19, 2025

Copy link
Copy Markdown

Android Build Available

Rocket.Chat Experimental 4.64.0.107008

Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNTi6SQeMhIufL8dtKuZT50EQ63JzTjO52-p2Ph4yp7qSO0cFLRy7o0AltrGd3hV4GfkZNmONGqhtxUO4Nc6

@Rohit3523 Rohit3523 marked this pull request as ready for review August 19, 2025 15:17
@diegolmello diegolmello merged commit 5eac5bd into develop Aug 19, 2025
20 of 32 checks passed
@diegolmello diegolmello deleted the fix-ci-setup branch August 19, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diegolmello diegolmello diegolmello approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Rohit3523 @diegolmello