Skip to content

Refactor #49: Replace raw resource dictionaries with typed structure#99

Open
cookie54345 wants to merge 2 commits into
Robbo-lab:mainfrom
cookie54345:refactor/typed-resource-definitions
Open

Refactor #49: Replace raw resource dictionaries with typed structure#99
cookie54345 wants to merge 2 commits into
Robbo-lab:mainfrom
cookie54345:refactor/typed-resource-definitions

Conversation

@cookie54345

Copy link
Copy Markdown
Collaborator

name: Pull Request
about: Submit your completed changes for review
title: "[PR] Replace raw resource dictionaries with typed structure"
labels: ["student-submission"]
assignees: []

Description

This repalces the raw dictionary definitions used for MCP resources with an ResourceDefinition dataclass structure.

Type of change

  • [ x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • test_resource_definition_fallback_logic: Verifies string resolution when fields are left blank.
  • test_resource_definition_fields: Verifies attributes are saved correctly on object creation.
  • test_register_resources_dry_run: Verifies proper dynamic template loop path formatting.
  • test_resource_definition_execution: Verifies dynamic callback function execution.

Checklist:

  • [ x] I have followed the coding style guidelines of this project
  • [ x] I have reviewed my own code
  • [ x] I have commented hard-to-understand areas of my code
  • [x ] I have added docstrings to all public functions/methods
  • [ x] I have used descriptive variable names to make by code easier to understand
  • [x ] I have made corresponding changes to the documentation
  • [ x] I have added tests that prove my fix is effective or that my feature works
  • [ x] New and existing unit tests pass locally with my changes

Related Issue(s)

fixes #49

@cookie54345 cookie54345 self-assigned this Jun 11, 2026
@cookie54345 cookie54345 force-pushed the refactor/typed-resource-definitions branch from 2bf769c to e761a10 Compare June 11, 2026 15:42
@cookie54345 cookie54345 requested a review from Robbo-lab June 12, 2026 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Refactor] Replace raw resource dictionaries with a typed structure

1 participant