docs: fix 20 documentation accuracy issues + add ADR-008#43
Merged
Conversation
commands.adoc: - asm --depth default: 3 → 2 (matches code) - mcp install: add missing --surface <essential|standard|full> flag - viz: add missing --scope and --resolution flags; remove bogus -j alias - heal: add structured flag table (--propose/--fix/--gc/--since/--apply/--watch) - status: document savings estimate output block ai-integration.adoc: - Replace two-tier Core/Extended model with three-tier Essential/Standard/Full - Fix tool assignments: search/list/communities/impact-diff were in wrong tier - Fix env var: ADEN_MCP_FULL=1 → ADEN_MCP_SURFACE=standard|full (legacy alias noted) - Document --surface flag at install time retrieval-levers.adoc: - Fix polarity: auto-gating is OFF by default, opt-in via ADEN_LEXICON_ON - Reframe ADEN_LEXICON_OFF as kill switch, not primary disable mechanism - Fix rerank trigger: code_anchor_fraction → query_looks_codey (query text only) - Fix NL-over-code behavior: expands only, does not rerank - Document PR #39/PR #40 revert history in status section architecture.adoc: - Add aden-paths node to Mermaid crate diagram - Remove duplicate aden-mcp Phase 2 row (already shipped as Phase 0) security-model.adoc: - Replace CanPerform (not a valid EdgeType) with Invokes in semantics example - Update malicious-contract-injection threat: moot since store-first (ADR-003) .agent/quick-ref.adoc: - Add --features watch caveat to aden watch entry crates/aden-cli/src/commands/init.rs: - Fix misleading "Knowledge graph built in .aden/store." message; store is in per-user data dir since ADR-003 docs/adr-008-current-implementation-state.adoc (new): - Document current scope extensions beyond original ADRs: Wave 3 edges (Supersedes/Justifies/AssociatedWith), GEN_LOGIC_VERSION=4, store-first architecture, MCP three-tier surface, dual-substrate retrieval (opt-in)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commands.adoc: fixasm --depthdefault (3→2); add missing--surfacetomcp install; add missing--scope/--resolutiontoviz; remove bogus-jalias fromviz; add structured flag table toheal; documentstatussavings estimate outputai-integration.adoc: replace stale two-tier Core/Extended MCP model with three-tier Essential/Standard/Full; fix tool tier assignments (search,list,communities,impact-diffwere in wrong tier); update env var fromADEN_MCP_FULL=1toADEN_MCP_SURFACE; document--surfaceat install timeretrieval-levers.adoc: fix polarity (auto-gating is OFF by default, opt-in viaADEN_LEXICON_ON); reframeADEN_LEXICON_OFFas kill switch; fix rerank trigger description (code_anchor_fraction→query_looks_codey); fix NL-over-code behavior (expand only, not both levers); document PR feat(search): enable dual-substrate auto-gating by default (opt-out via ADEN_LEXICON_OFF) #39/PR fix(search): guard dual-substrate lexicon levers (opt-in) + index .asc AsciiDoc #40 revert historyarchitecture.adoc: addaden-pathsto Mermaid diagram; remove duplicateaden-mcpPhase 2 rowsecurity-model.adoc: replaceCanPerform(not a valid EdgeType) withInvokes; update malicious-contract-injection threat row to reflect store-first reality.agent/quick-ref.adoc: add--features watchcaveat toaden watchentrycrates/aden-cli/src/commands/init.rs: fix misleading "built in.aden/store" message — store is in per-user data dir since ADR-003docs/adr-008-current-implementation-state.adoc(new): living state document covering scope extensions beyond original ADRs — Wave 3 edges (Supersedes/Justifies/AssociatedWith, GEN_LOGIC_VERSION=4), store-first architecture, MCP three-tier surface, dual-substrate retrieval (opt-in). Original ADRs left intact as historical records.All 20 issues validated against source before fixing:
aden understandfor symbols, Bash for string-literal env vars.Test plan
cargo test --workspacegreencargo clippy --workspacecleancargo fmt --allappliedLicense checklist (required for any Cargo.toml change)