[EPAC-897]: MP attendance record: show how often each MP votes and how often they miss divisions#802
Merged
riddim-developer-bot[bot] merged 3 commits intoJun 14, 2026
Conversation
riddim-developer-bot
Bot
force-pushed
the
symphony/epac-897-mp-attendance-record-show-how-often-each-mp-vote
branch
from
371c6b2 to
51e41b3
Compare
riddim-developer-bot
Bot
deleted the
symphony/epac-897-mp-attendance-record-show-how-often-each-mp-vote
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the iOS-side verification tests, snapshots, localizations, and documentation for the MP attendance record feature, fulfilling the EPAC-897 requirements.
Changes:
AttendanceRecordandMPAttendancecomputed models correctly distinguish paired absences (which are pre-arranged and not treated the same as unexplained absences) and avoid counting divisions before the member was sworn in.MPAttendanceQueryPortfor querying raw tallies.SwiftDataMPAttendanceAdaptermapsMemberVote.typecounts ("yea", "nay", "paired", "absent") accurately.MemberAttendanceSectiondisplays the headline percentage with denominator (e.g. "Present 89% of the time — 412 of 463 divisions since [date sworn in]").LoadMPAttendanceuse case todocs/architecture/use-case-catalog.md.fr.lproj/Localizable.strings.LoadMPAttendanceTeststo cover use case logic, including rate calculation and peer averages.SwiftDataMPAttendanceAdapterTeststo cover the database queries and the sworn-in date exclusions.SnapshotTestswith standard and no-date/no-comparison states for theAttendanceRecordCardview, generating and committing the reference images.Verification
xcodebuild testfor the unit tests:LoadMPAttendanceTestspassed.SwiftDataMPAttendanceAdapterTestspassed.xcodebuild testfor the snapshot tests:SnapshotTests/testMPAttendanceCard_standardpassed.SnapshotTests/testMPAttendanceCard_noDateNoComparisonpassed.bash scripts/check-boundaries.shto confirm no Clean Architecture boundary violations.