Skip to content

Trim AGENTS.md and drop tailnet handback note#1229

Merged
RhysSullivan merged 1 commit into
mainfrom
trim-agents-md
Jun 30, 2026
Merged

Trim AGENTS.md and drop tailnet handback note#1229
RhysSullivan merged 1 commit into
mainfrom
trim-agents-md

Conversation

@RhysSullivan

Copy link
Copy Markdown
Owner

Condenses AGENTS.md to its contracts while keeping every rule intact (131 to 83 lines).

  • Removes the handback note about leaving the dev server reachable over the user's tailnet with credentials; the handback section now just says to leave the dev server running to poke at.
  • Collapses the three-part handback section into one paragraph and tightens Task Completion, Service Emulators, Engineering Priorities, and Package Roles to terse bullets.
  • Keeps: Effect Vitest / never bun test, the merge gates and format rule, the standalone-emulators autonomy note, no-attribution and public-PR rules, collaboration notes, .reference repos, and the MISTAKES/DESIRES/LEARNINGS pointers.

@RhysSullivan RhysSullivan merged commit 058c04d into main Jun 30, 2026
11 of 13 checks passed
@RhysSullivan RhysSullivan deleted the trim-agents-md branch June 30, 2026 19:31
@greptile-apps

greptile-apps Bot commented Jun 30, 2026

Copy link
Copy Markdown

Greptile Summary

This PR condenses AGENTS.md from 131 to 83 lines by tightening prose, collapsing the three-part handback section into a single paragraph, and intentionally removing the tailnet/credentials handback detail.

  • All major contracts are preserved: Effect Vitest / never bun test, merge gates, emulator autonomy, no-attribution, em-dash ban, .reference repos, and MISTAKES/DESIRES/LEARNINGS pointers.
  • The merge-gate command list now reads bun run format:check, lint, typecheck, test, dropping bun run from three of the four commands, which introduces an ambiguous invocation for AI agents parsing this file as executable instructions.

Confidence Score: 3/5

The condensed AGENTS.md is safe to merge after fixing the abbreviated merge-gate commands.

The file is the primary machine-readable instruction set for AI agents in this repo. Three of the four merge-gate commands have their bun run prefix stripped, leaving bare lint, typecheck, and test that an agent would likely fail to execute correctly. Every other rule is faithfully preserved.

AGENTS.md — specifically the Task Completion section's merge-gate command list.

Important Files Changed

Filename Overview
AGENTS.md Documentation condensed from 131 to 83 lines; all major rules preserved, but the merge-gate command list drops bun run from lint, typecheck, and test, creating ambiguous bare-command references that agents may execute incorrectly.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Agent reads AGENTS.md] --> B{Change touches user-visible work?}
    B -- Yes --> C[Run scoped tests: vitest run ...]
    B -- No --> C
    C --> D{Merge-ready / broad change?}
    D -- Yes --> E["Run full gates: bun run format:check\nbun run lint\nbun run typecheck\nbun run test"]
    D -- No --> F[Hand back with evidence]
    E --> G[bun run format before PR\nstage only touched files]
    G --> F
    F --> H[Link e2e run + leave dev server running\n+ list paths worth manual exercise]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[Agent reads AGENTS.md] --> B{Change touches user-visible work?}
    B -- Yes --> C[Run scoped tests: vitest run ...]
    B -- No --> C
    C --> D{Merge-ready / broad change?}
    D -- Yes --> E["Run full gates: bun run format:check\nbun run lint\nbun run typecheck\nbun run test"]
    D -- No --> F[Hand back with evidence]
    E --> G[bun run format before PR\nstage only touched files]
    G --> F
    F --> H[Link e2e run + leave dev server running\n+ list paths worth manual exercise]
Loading

Reviews (1): Last reviewed commit: "Trim AGENTS.md and drop tailnet handback..." | Re-trigger Greptile

Comment thread AGENTS.md
Comment on lines 17 to 18
## Handing Back Work: Evidence, Not Assertions

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Abbreviated commands lose bun run prefix

The new line lists the full gates as bun run format:check, lint, typecheck, test — only the first command keeps its bun run prefix. Since this file is parsed by AI agents as executable instructions, an agent following this literally may run lint, typecheck, or test as bare shell commands instead of bun run lint, bun run typecheck, bun run test. The original spelled each one out in full to prevent exactly this ambiguity.

Suggested change
## Handing Back Work: Evidence, Not Assertions
work the full gates are `bun run format:check`, `bun run lint`, `bun run typecheck`, `bun run test`.

Context Used: AGENTS.md (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Cloudflare preview

Torn down — the PR is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant