chore(devnet): bump Perp OB routers to 1.1.2#495
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (10)
📝 WalkthroughWalkthroughUpdates V2 fill inputs and EIP-712 hashing to include signed orders and metadata, migrates perp and spot tests, revises fee-model coverage, adds devnet tests, serializes Forge execution, and advances router package versions. ChangesV2 fill contracts and hashing
Perp fill flow and fee validation
Spot, collateral, and permission flow migration
Devnet coverage and configuration
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant PerpFillTest
participant FillHashingV2
participant OrdersGateway
PerpFillTest->>FillHashingV2: hash orders, fill details, deadline, and metadata
FillHashingV2->>PerpFillTest: return signed matching-engine digest
PerpFillTest->>OrdersGateway: submit ExecuteFillInputV2
OrdersGateway->>OrdersGateway: validate metadata-bound signature
Possibly related issues
Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Checkov (3.3.8)packages/tests/package.jsonTraceback (most recent call last): Comment |
Summary
1.0.9to1.0.101.1.2SignedOrderfill envelope and opaque metadata bytes from reya-network #698This upgrades the devnet OrdersGateway to the ABI used by Reya-Labs/reya-chain#195. The generated
batchExecuteFillselector is0x7e3e0fd1.Fork-check enrichment
The refreshed suite now proves:
marketZeroFeesandexchangeZeroFeesstate cannot bypass fee model V3Validation
Local:
yarn lint:checkyarn buildforge buildreya-devnet-omnibus:1.0.10against the devnet forkforge inspect IOrdersGatewayProxyV2 methodsconfirmsbatchExecuteFill = 0x7e3e0fd11.1.2@routerpackages from reya-network #698 head1b09e14698f2ab83f2ad9a4dd63d265bf0efde32on chain ID 13370The workflow retains its existing warning-only devnet semantics while we agree the required-check policy separately. A clean hosted devnet run also depends on the four exact router packages being published to the Cannon registry; they currently exist only in the local Cannon cache used for this validation.
This PR stays draft until the exact-head GitHub checks are reviewed and the router-package publication prerequisite is resolved.
No package was published and no environment was deployed.
Fork-check follow-ups
This PR covers the immediate router, ABI, signing, and fee-model regressions. Broader checks remain intentionally separate:
Summary by CodeRabbit
New Features
Bug Fixes
Chores