Skip to content

feat: test ramber rebal#489

Open
ioanaroceanu2000 wants to merge 5 commits into
mainfrom
feat/bridge-amber
Open

feat: test ramber rebal#489
ioanaroceanu2000 wants to merge 5 commits into
mainfrom
feat/bridge-amber

Conversation

@ioanaroceanu2000

@ioanaroceanu2000 ioanaroceanu2000 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features
    • Added a new ad-hoc fork-test workflow for running a multi-step rebalance sequence in order.
    • Supports a full transaction flow that includes token approval, deposit, collateral setup, and automated rebalance triggering.

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 725acf89-2aad-4ed1-a5ff-69acb6dbe9bb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Adds utils/adhoc_ramber_rebalance_test.toml defining a five-step fork-test invoke chain (USDC approve → rUSD deposit → rUSD approve → setGlobalCollateralConfigtriggerAutoRebalance) with inline ABIs and depends ordering. The file is registered in reya_network.toml's include list.

Changes

RAMBER Rebalance Fork-Test Config

Layer / File(s) Summary
Five-step invoke chain and network wiring
packages/tomls/src/omnibus/utils/adhoc_ramber_rebalance_test.toml, packages/tomls/src/omnibus/reya_network.toml
New TOML defines USDC approve, rUSD deposit, rUSD approve, setGlobalCollateralConfig, and triggerAutoRebalance invocations with inline ABIs and depends edges enforcing execution order; the file is added to the omnibus include list.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A rabbit hops through fork-land with glee,
Approving USDC, wrapping rUSD with flair,
Five steps in order, depends chained with care,
RAMBER rebalanced—collateral set free,
🐇 autoRebalance leaps through the air!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: adding an ad-hoc RAMBER rebalance test TOML config.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/bridge-amber

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/tomls/src/omnibus/reya_network.toml`:
- Line 19: The shared reya_network omnibus currently includes the fork-only
adhoc batch, which makes all reya_network:test and reya_network:simulate runs
depend on fork state and the 250k USDC owner precondition. Remove the
utils/adhoc_ramber_rebalance_test.toml include from reya_network.toml and move
it into a separate adhoc entrypoint or add an explicit opt-in gate so only the
RAMBER dry-run loads it, keeping the default reya_network entrypoint isolated.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: a0232dcb-f547-4613-a127-8f88381ecbff

📥 Commits

Reviewing files that changed from the base of the PR and between b6bf111 and 12d80a6.

📒 Files selected for processing (2)
  • packages/tomls/src/omnibus/reya_network.toml
  • packages/tomls/src/omnibus/utils/adhoc_ramber_rebalance_test.toml

"../share_token/mainnet.toml",
"../sbt/mainnet.toml",
"../rotations/mainnet.toml",
"utils/adhoc_ramber_rebalance_test.toml",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

Isolate the adhoc batch from the default reya_network entrypoint.

Line 19 now makes every reya_network:test and reya_network:simulate consumer load a fork-only batch that the new file itself says depends on settings.owner holding at least 250k USDC on the latest fork. That turns a one-off RAMBER dry-run into global behavior for the shared omnibus and makes unrelated runs fork-state-dependent. Please move this include to a dedicated adhoc entrypoint or gate it behind an explicit opt-in instead of wiring it into reya_network.toml.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/tomls/src/omnibus/reya_network.toml` at line 19, The shared
reya_network omnibus currently includes the fork-only adhoc batch, which makes
all reya_network:test and reya_network:simulate runs depend on fork state and
the 250k USDC owner precondition. Remove the
utils/adhoc_ramber_rebalance_test.toml include from reya_network.toml and move
it into a separate adhoc entrypoint or add an explicit opt-in gate so only the
RAMBER dry-run loads it, keeping the default reya_network entrypoint isolated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant