feat: test ramber rebal#489
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughAdds ChangesRAMBER Rebalance Fork-Test Config
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/tomls/src/omnibus/reya_network.toml`:
- Line 19: The shared reya_network omnibus currently includes the fork-only
adhoc batch, which makes all reya_network:test and reya_network:simulate runs
depend on fork state and the 250k USDC owner precondition. Remove the
utils/adhoc_ramber_rebalance_test.toml include from reya_network.toml and move
it into a separate adhoc entrypoint or add an explicit opt-in gate so only the
RAMBER dry-run loads it, keeping the default reya_network entrypoint isolated.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: a0232dcb-f547-4613-a127-8f88381ecbff
📒 Files selected for processing (2)
packages/tomls/src/omnibus/reya_network.tomlpackages/tomls/src/omnibus/utils/adhoc_ramber_rebalance_test.toml
| "../share_token/mainnet.toml", | ||
| "../sbt/mainnet.toml", | ||
| "../rotations/mainnet.toml", | ||
| "utils/adhoc_ramber_rebalance_test.toml", |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
Isolate the adhoc batch from the default reya_network entrypoint.
Line 19 now makes every reya_network:test and reya_network:simulate consumer load a fork-only batch that the new file itself says depends on settings.owner holding at least 250k USDC on the latest fork. That turns a one-off RAMBER dry-run into global behavior for the shared omnibus and makes unrelated runs fork-state-dependent. Please move this include to a dedicated adhoc entrypoint or gate it behind an explicit opt-in instead of wiring it into reya_network.toml.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/tomls/src/omnibus/reya_network.toml` at line 19, The shared
reya_network omnibus currently includes the fork-only adhoc batch, which makes
all reya_network:test and reya_network:simulate runs depend on fork state and
the 250k USDC owner precondition. Remove the
utils/adhoc_ramber_rebalance_test.toml include from reya_network.toml and move
it into a separate adhoc entrypoint or add an explicit opt-in gate so only the
RAMBER dry-run loads it, keeping the default reya_network entrypoint isolated.
Summary by CodeRabbit