Repository navigation
Runner: netplay through a loadable recomp-net module - #5
Merged
Merged
Conversation
…DULE) --net-module / RETRO_NETPLAY_MODULE names librecomp_net_module; the runner checks ABI, rbengine and every symbol it calls at start, folds the module's wire version into the build fingerprint, and links no recomp-net. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The recomp-net module ABI the runner loads (0 when netplay is linked in), so a host installs a module with that ABI without opening it; runner_probe reads it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-DRETRO_RUNTIME_NETPLAY_MODULE=ON(withRETRO_RUNTIME_RECOMP_NET_DIRfor headers only) buildsretro-core-runnerwithout linking recomp-net. It openslibrecomp_net_module(recomp-net PR #31, released from v0.1.0) at run time from--net-module <path>orRETRO_NETPLAY_MODULE.runner/net_module.*:dlopen, checks the module ABI, rbengine, and every function the runner calls; refuses by name, no fallback. The module's wire version joins the build fingerprint (runner_netplay: MODULE …logs which module played).--versionprintsnetplay_module_abi N(0 when netplay is linked in) andrunner_probereads it, so a host can install the module with that ABI without opening it (retcomm-launcher uses this).--versionline.Verified: all 29 ctests; a missing/bad/wrong module is refused with the reason; two runner processes on loopback, Pokemon Stadium (n64lle generic core), 300 frames, identical
state_hash, 0 desyncs, through the v0.1.0-equivalent module (ABI 1, wire 2). Not verified: macOS/Windows module builds of the runner, a netplay session through the hub.🤖 Generated with Claude Code