feat(txt): properties table + TxtTables namespace for the data tables#4
Merged
Conversation
Expose the Diablo II data (.txt) tables more fully.
- properties.txt: add the property -> (func, stat, set, val) table that
affixes / runewords / set bonuses resolve their mods through. Record
layout verified against Game.exe (TXT_AllocTxt_properties, 0x2e-byte
records) and D2MOO (D2PropertiesTxt; pointer/count at sgptDataTables
+0xa4/+0xac).
- TxtTables: a non-constructable namespace class (like HttpClient's
static methods) with names(), size(table), columns(table),
row(table, id) and value(table, id, column) - the same machinery as
getBaseStat, with method names that don't stutter.
- getBaseStat(table, row) with no column now returns the whole row as a
{column: value} object.
- game::GetTxtTableRowCount primitive backs size(); shared cell/row
marshaling lives in api/globals/TxtTableAccess.h.
- gen_txt_tables.py appends properties; TxtTables.h regenerated.
Owner
Author
|
/ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the Diablo II data (.txt) tables more fully.