chore: pin clang-format version and format the tree#3
Merged
Conversation
CI's format check ran whatever clang-format the windows-latest VS bundles, which drifts from the local VS clang-format - notably it infers pointer alignment (East vs West) differently by version, so `check-format` passed locally yet failed in CI (e.g. V8Host.h), turning every PR's format job red regardless of what the PR changed. - build.ps1: prefer a PATH clang-format pinned to $PINNED_CLANG_FORMAT (20.1.8), falling back to the VS-bundled tool for local dev. The version probe is quiet so a non-clang-format `clang-format` shim on PATH (e.g. a Chromium depot_tools wrapper) is ignored rather than erroring. - ci.yml: `pip install clang-format==20.1.8` in the format job so CI uses the pinned version (kept in sync with build.ps1). - Reformat the tree under the pinned version: Version.h's nested #define is indented per IndentPPDirectives: BeforeHash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI's format check ran whatever clang-format the windows-latest VS bundles, which drifts from the local VS clang-format - notably it infers pointer alignment (East vs West) differently by version, so
check-formatpassed locally yet failed in CI (e.g. V8Host.h), turning every PR's format job red regardless of what the PR changed.clang-formatshim on PATH (e.g. a Chromium depot_tools wrapper) is ignored rather than erroring.pip install clang-format==20.1.8in the format job so CI uses the pinned version (kept in sync with build.ps1).