fix: run the backend under its own "claude-smart" org id#85
Open
yyiilluu wants to merge 1 commit into
Open
Conversation
claude-smart and the enterprise self-host backend both defaulted to the "self-host-org" org and fought over ~/.reflexio/configs/config_self-host-org.json, corrupting each other's storage_config. Set REFLEXIO_DEFAULT_ORG_ID=claude-smart in backend-service.sh (hard-set, not :-defaulted, so a value in the shared ~/.reflexio/.env can't drag us back onto self-host-org), and point the CLI's config-path constant at config_claude-smart.json to match. Relies on the reflexio backend reading REFLEXIO_DEFAULT_ORG_ID for the no-auth org resolver. Update the clear-all test fixture to the new config path.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe backend service now exports ChangesOrg config alignment
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
claude-smart's vendored backend and the enterprise self-host backend both defaulted to the
self-host-orgorg, so they shared and clobbered~/.reflexio/configs/config_self-host-org.json— corrupting each other'sstorage_config.This runs claude-smart's backend under its own
claude-smartorg id, giving it a dedicatedconfig_claude-smart.jsonand ending the collision.Changes
plugin/scripts/backend-service.sh—export REFLEXIO_DEFAULT_ORG_ID="claude-smart"(hard-set, not:--defaulted, so a value in the shared~/.reflexio/.envcan't drag us back ontoself-host-org).plugin/src/claude_smart/cli.py— config-path constant now derives from_REFLEXIO_ORG_ID = "claude-smart"→config_claude-smart.json, kept in sync with the export.tests/test_cli_clear_all.py— fixture updated to the new config path.Relies on the reflexio backend reading
REFLEXIO_DEFAULT_ORG_IDfor the no-auth org resolver (companion change in the reflexio package).Test Plan
pytest tests/test_cli_clear_all.py— 16 passed.Summary by CodeRabbit