Repository navigation
ci: quiet the build warnings (CS3021, Node 20 actions) - #49
Merged
Merged
Conversation
The ANTLR-generated grammar files mark each class [CLSCompliant(false)] and the assembly declares no CLS compliance, so every build warned CS3021 four times. An .editorconfig rule silences it for those four files only. actions/checkout and actions/setup-dotnet move to their current majors, which run on Node 24. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the warnings every CI run shows, including on PR #47 and on main.
Features
.editorconfigrule scoped to those four files. Handwritten code is still checked, and regenerating the parser won't bring them back.actions/checkoutv4 → v7 andactions/setup-dotnetv4 → v6 inci.ymlandpublish.yml. Both run on Node 24, which removes the Node 20 deprecation warning. Their breaking changes don't apply here: checkout v7 only blocks fork PRs underpull_request_targetandworkflow_run.Local:
dotnet build0 warnings (was 8), tests 34/34.