Skip to content

Cherry-pick: Expose EditorNode3DGizmo::is_selected in GDScript. - #1463

Open
JoltedJon wants to merge 1 commit into
Redot-Engine:masterfrom
JoltedJon:cherry-5
Open

JoltedJon wants to merge 1 commit into
Redot-Engine:masterfrom
JoltedJon:cherry-5

Conversation

@JoltedJon

@JoltedJon JoltedJon commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Brings in godotengine/godot#110421

Summary by CodeRabbit

  • New Features
    • Added EditorNode3DGizmo.is_selected() to the class reference and scripting API. It reports whether a gizmo is selected, allowing its display to be adjusted during redraw.

@JoltedJon
JoltedJon requested review from a team October 1, 2026 18:17
@JoltedJon JoltedJon added this to the Redot 26.4 milestone Oct 1, 2026
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: Redot-Engine/redot-engine/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: dc4bf500-27f0-484c-80f2-7d9572efc05d

📥 Commits

Reviewing files that changed from the base of the PR and between 80d31f7 and 0d944e1.

📒 Files selected for processing (2)
  • doc/classes/EditorNode3DGizmo.xml
  • editor/scene/3d/node_3d_editor_gizmos.cpp

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review.


Walkthrough

The EditorNode3DGizmo scripting API now exposes is_selected(). The class reference documents its boolean return value and use during _redraw.

Changes

Gizmo selection API

Layer / File(s) Summary
Document and register selection method
doc/classes/EditorNode3DGizmo.xml, editor/scene/3d/node_3d_editor_gizmos.cpp
The class reference documents is_selected() and its boolean return value. The method is registered as callable in the scripting API.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Feature

Suggested reviewers: arctis-fireblight, generalprotectionfault

Merge Risk: ⚪ Minimal · up to 0d944

This additive editor API exposes the gizmo’s existing selection state; no actionable merge risk is evident.

Architecture Summary

Architecture risk: 🔵 Low · up to 0d944

The change affects 2 systems.

Changed systems: editor, doc

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — editor (service) was modified; 1 changed file maps to changed impact.
  • observed — doc (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in doc/classes/EditorNode3DGizmo.xml: Added the is_selected() method documentation, specifying a boolean return and describing its use to check gizmo selection during _redraw.
  • observed — Modified behavior in editor/scene/3d/node_3d_editor_gizmos.cpp: is_selected is now registered as a callable EditorNode3DGizmo method.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: exposing EditorNode3DGizmo::is_selected in GDScript.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants