Use timeout instead of num_sec with integer values#307
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideReplaces the deprecated Sequence diagram for internal wait_for timeout usage changesequenceDiagram
participant Browser
participant wait_for
Browser->>wait_for: _check_for_new_pages, timeout=1.0, delay=0.05, message, silent_failure
wait_for-->>Browser: result
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
d25ff86 to
709e780
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the wait_for usage in widgetastic.browser to use the timeout keyword argument instead of the deprecated num_sec, aligning the codebase with the upcoming wait_for v2 API.
Changes:
- Replaced
num_sec=1.0withtimeout=1.0in the short best-effort new-page detection wait.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #307 +/- ##
=======================================
Coverage 92.72% 92.72%
=======================================
Files 19 19
Lines 2750 2750
=======================================
Hits 2550 2550
Misses 200 200
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0925172 to
d1ec4ce
Compare
preparation for wait_for v2 Co-authored-by: Claude <noreply@anthropic.com>
6a12ce7 to
e162439
Compare
for more information, see https://pre-commit.ci
preparation for wait_for v2
the timeout kwarg should be an integer, float, or timedelta instance.
Summary by Sourcery
Enhancements: