FIXED : While selecting any answer the space bar hit showing question is SKIPPED instead of telling INCORRECT ANSWER#72
Open
agneee-dev wants to merge 3 commits into
Open
Conversation
|
@agneee-dev is attempting to deploy a commit to the razen04's projects Team on Vercel. A member of the Team first needs to authorize it. |
Razen04
reviewed
May 3, 2026
Razen04
changed the title
Razen04
reviewed
May 3, 2026
| <Eye className="inline text-lg" /> | ||
| <span className="hidden md:inline ml-2"> | ||
| Submit <span className="font-mono">[⎵/↵]</span> | ||
| Submit {hasSelection && <span className="font-mono">[⎵/↵]</span>} |
Owner
There was a problem hiding this comment.
This just makes it does not appear until the answer is not selected but it will still work regardless keeping this does not make sense I think. Instead what we can do is disable the Submit button until something is selected or typed in case of NAT and keep the Show Answer as always working cause that is the surrender button.
This will be better UX. Otherwise the thing is already fixed.
Author
There was a problem hiding this comment.
okay - I am on to it ... i'll let you know after modifying
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implemented keyboard shortcuts to speed up the practice flow and refactored the PracticeCard component into a modular, hook-based architecture.
New Shortcuts:
Q / W (or Arrows): Previous/Next question.
Enter / Space: Submit (if selected) or Show Answer (if empty).
1-5 / A-E: Select options.
/: Open explanation.
Refactor:
Decoupled PracticeCard logic into useAnswerFlow, useQuestionState, and useQuestionNav for better maintainability.
How should this be manually tested?
What are the relevant tickets?
Fixes #71