Fix: clean up 402 error description after API balance exposure removal (#230)#242
Conversation
API PR #19971 simplified the 402 insufficient_credits response detail to a generic message. Injecting it into the n8n error description caused duplicate "top up" messaging. Now the description links directly to the billing page.
RapierCraft
left a comment
There was a problem hiding this comment.
APPROVED: commit cc74af5 after context-aware review (1 agent: General Security). 0 findings. Safe to merge.
Review scope: TypeScript error handler sync — 1 line removed from 402 description in handleApiError.
Checks passed:
- Build:
npm run build— clean - Prettier: unchanged
- Secrets: none
- Env vars: none
- Integration:
handleApiErroris the sole 402 dispatcher, all resource callers unaffected - Security: No information disclosure concern — change removes redundant balance detail from user-facing error (consistent with API PR #19971 privacy intent)
RapierCraft
left a comment
There was a problem hiding this comment.
APPROVED: commit cc74af5 after context-aware review (1 agent: General Security). 0 findings. Safe to merge.
|
APPROVED: commit cc74af5 after context-aware review (1 agent: General Security). 0 findings. Safe to merge. Checks: Build pass | Prettier pass | No secrets | No env vars | Integration verified | Security clean |
PR Review Summary: #242 - Fix: clean up 402 error description after API balance exposure removal (#230)Review IntegrityReviewed commit: Verdict: APPROVEDContext-Aware ReviewDomains: n8n node TypeScript | Agents: 1 (General Security — inline) Integration Checks (Phase 2.5)Code registration: PASS — node registered in Risk Matrix
FindingsNo findings. Automated Checks
RecommendationChange is minimal, correct, and consistent with API PR #19971's intent to remove balance exposure from error responses. Merged. Context-aware review complete. 1 agent + integration checks. 0 findings triaged. PR merged to |
Summary
${detail}into the description, which now produces a redundant/duplicated "Please top up" message${detail}.prefix from the 402 case — description now cleanly links to the billing pageChanges
nodes/AlterLab/AlterLab.node.ts: Remove${detail}.from 402 error description inhandleApiErrorTesting
detailin their descriptionsCloses #230
Implementation branch:
fix/sync-balance-402-error-230Base:
main