Feat: add extraction_provider field for BYOK key selection (Scrape, Crawl, Extract)#240
Conversation
…y selection (#227) - Add Extraction Provider options field (openai/anthropic/openrouter/groq) to Scrape Extraction collection - Add Extraction Provider options field to Crawl Settings collection - Add Extraction Provider options field to Extract Options collection - Wire extraction_provider into API payload builders for all three resources - Update TypeScript type interfaces for extraction, settings, and opts Syncs n8n node with AlterLab API extraction_provider parameter introduced alongside BYOK key resolution.
RapierCraft
left a comment
RapierCraft
left a comment
There was a problem hiding this comment.
APPROVED: commit 7ca99d2 after context-aware review (0 domain agents needed — pure TypeScript field additions, no risk signals).
Review scope: Single-file n8n node definition change (+56 lines, 0 deletions).
Checks performed:
- Build verification:
npm run build→ PASS (tsc + gulp icons) - Secrets detection: PASS (none found)
- Env var audit: PASS (no new vars)
- Integration check: All 3 field definitions present (lines 544, 894, 1283) with matching body-wiring (lines 2199, 2560, 2998)
- Default behavior:
default: ""withvalue: ""for Auto option — conditionalif (extraction.extractionProvider)correctly evaluates as falsy → param omitted from API request when Auto is selected ✓
0 findings. Safe to merge.
RapierCraft
left a comment
RapierCraft
left a comment
There was a problem hiding this comment.
APPROVED: commit 7ca99d2 after context-aware review (0 domain agents needed — pure TypeScript field additions, no risk signals).
Review scope: Single-file n8n node definition change (+56 lines, 0 deletions).
Checks performed:
- Build verification:
npm run build→ PASS (tsc + gulp icons) - Secrets detection: PASS (none found)
- Env var audit: PASS (no new vars)
- Integration check: All 3 field definitions present (lines 544, 894, 1283) with matching body-wiring (lines 2199, 2560, 2998)
- Default behavior:
default: ""withvalue: ""for Auto option — conditionalif (extraction.extractionProvider)correctly evaluates as falsy → param omitted from API request when Auto is selected
0 findings. Safe to merge.
PR Review Summary: #240 — Feat: add extraction_provider field for BYOK key selectionReview IntegrityReviewed commit: Verdict: APPROVEDContext-Aware ReviewDomains: TypeScript / n8n node definition | Agents: 0 (no risk signals detected) Integration Checks (Phase 2.5)Field registration: PASS — extractionProvider defined in Scrape (line 544), Crawl (line 894), Extract (line 1283) collections Risk Matrix
FindingsNone. Automated Checks
RecommendationMerged to Context-aware review complete. 0 agents + integration checks. 0 findings triaged. PR merged. |
1 participant
Summary
extraction_provideroptions field (Auto / OpenAI / Anthropic / OpenRouter / Groq) to Scrape Extraction collection, Crawl Settings, and Extract Optionsextraction_providerinto API request payload for all three resourcesextraction_modelpattern added in Sync: Add extraction_model field to Scrape, Extract, and Crawl resources (from #19988) #234Note:
extraction_modelwas already present in all 3 resources. Onlyextraction_providerwas missing.Changes
nodes/AlterLab/AlterLab.node.ts: +56 lines — 3 field definitions + 3 TypeScript type updates + 3 body-wiring blocksTesting
extraction_provider: "openai"in API request bodyextraction_providerfrom API requestnpm run buildpassesCloses #227
Implementation branch:
feat/byok-provider-227Base:
main