Fix: sync content.json extraction_schema response behavior (#225)#238
Conversation
) When extraction_schema is provided, the API now overrides content.json with the filtered/extracted schema result (PR #19898). Update code comments to document that output.json carries the extraction result in this case. The top-level filtered_content key is still returned by the API, so output.filteredContent remains populated as a secondary path.
PR Review — #238Reviewed commit: Verdict: APPROVEDAgents: General Security scan (inline — no risk signals detected, comment-only change) Review SummaryThis PR is a comment-only update to What changed:
Automated Checks
Integration Checks (Phase 2.5)No activation path changes — comment-only update. Node registration unchanged. FindingsNo findings. Change is purely documentary. Context-aware review complete. 0 blocking findings. |
PR Review Summary: #238 — Fix: sync content.json extraction_schema response behavior (#225)Review IntegrityReviewed commit: Verdict: APPROVED ✅ — MergedContext-Aware ReviewDomains: TypeScript/n8n node | Agents: General Security (inline) | Risk signals: None Integration Checks (Phase 2.5)Code registration: ✅ Pass — comment-only, no registration changes Risk Matrix
FindingsNone — change is purely documentary. Automated Checks
RecommendationApproved and merged. Comment update accurately reflects the API semantic change from PR #19898. 1 agent (inline) + integration checks. 0 findings. PR merged to |
Summary
API change from PR #19898 (AlterLab backend): when
extraction_schemais provided, the API now overridescontent.jsonwith the filtered/extracted schema result. This updates code comments to document the new semantic — no logic change is needed since the node already readscontent.jsoncorrectly.Changes
nodes/AlterLab/AlterLab.node.ts: Updated comments in the scrape output formatting block to clarify thatoutput.jsoncarries the extraction result whenextraction_schemais used.output.filteredContentremains as a secondary path (top-levelfiltered_contentstill returned by API).Testing
npm run buildpassesCloses #225
Closes #226
Implementation branch:
fix/sync-scrape-content-json-225Base:
main