Skip to content

Fix: sync content.json extraction_schema response behavior (#225)#238

Merged
RapierCraft merged 1 commit into
mainfrom
fix/sync-scrape-content-json-225
Jun 3, 2026
Merged

Fix: sync content.json extraction_schema response behavior (#225)#238
RapierCraft merged 1 commit into
mainfrom
fix/sync-scrape-content-json-225

Conversation

@RapierCraft

Copy link
Copy Markdown
Owner

Summary

API change from PR #19898 (AlterLab backend): when extraction_schema is provided, the API now overrides content.json with the filtered/extracted schema result. This updates code comments to document the new semantic — no logic change is needed since the node already reads content.json correctly.

Changes

  • nodes/AlterLab/AlterLab.node.ts: Updated comments in the scrape output formatting block to clarify that output.json carries the extraction result when extraction_schema is used. output.filteredContent remains as a secondary path (top-level filtered_content still returned by API).

Testing

  • npm run build passes
  • Prettier applied
  • No merge commits in ancestry

Closes #225
Closes #226
Implementation branch: fix/sync-scrape-content-json-225
Base: main

)

When extraction_schema is provided, the API now overrides content.json
with the filtered/extracted schema result (PR #19898). Update code
comments to document that output.json carries the extraction result in
this case. The top-level filtered_content key is still returned by the
API, so output.filteredContent remains populated as a secondary path.
@RapierCraft

Copy link
Copy Markdown
Owner Author

PR Review — #238

Reviewed commit: 08ed3d9 | Status: CURRENT


Verdict: APPROVED

Agents: General Security scan (inline — no risk signals detected, comment-only change)

Review Summary

This PR is a comment-only update to nodes/AlterLab/AlterLab.node.ts. No logic changes, no new code paths, no imports added or removed.

What changed:

  1. Added a 3-line comment explaining that output.json carries the schema-filtered extraction result when extraction_schema is used (API semantic change from PR #19898)
  2. Updated the "Extraction results" comment to note that top-level filtered_content is still returned by the API
  3. Prettier reformatted two long description strings (wrapping only — no semantic change)

Automated Checks

Check Result
npm run build (tsc + gulp) ✅ PASS
Prettier formatting ✅ Applied
Secrets detection ✅ None found
New env vars ✅ None
SQL injection ✅ N/A
SSRF ✅ N/A
Ancestry (no merge commits) ✅ Clean

Integration Checks (Phase 2.5)

No activation path changes — comment-only update. Node registration unchanged.

Findings

No findings. Change is purely documentary.


Context-aware review complete. 0 blocking findings.

@RapierCraft RapierCraft merged commit 9f9bdba into main Jun 3, 2026
3 checks passed
@RapierCraft

Copy link
Copy Markdown
Owner Author

PR Review Summary: #238 — Fix: sync content.json extraction_schema response behavior (#225)

Review Integrity

Reviewed commit: 08ed3d9 | Current HEAD: 08ed3d9 | Status: CURRENT

Verdict: APPROVED ✅ — Merged

Context-Aware Review

Domains: TypeScript/n8n node | Agents: General Security (inline) | Risk signals: None

Integration Checks (Phase 2.5)

Code registration: ✅ Pass — comment-only, no registration changes
SOPS deploy chain: N/A
Purpose Regression Gate (7A): N/A — non-milestone PR

Risk Matrix

Category Risk Blocking? Confidence
Security None No N/A
Logic None No N/A
Build None No Confirmed pass

Findings

None — change is purely documentary.

Automated Checks

Check Result
npm run build ✅ PASS
Prettier ✅ Applied
Secrets detection ✅ None
Ancestry ✅ Clean

Recommendation

Approved and merged. Comment update accurately reflects the API semantic change from PR #19898.


1 agent (inline) + integration checks. 0 findings. PR merged to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sync: Scrape API modification (from #19900) Sync: Scrape API modification (from #19899)

1 participant