Remove ndk-context dependency#220
Merged
Merged
Conversation
Instead of mixing data from `ndk-context` and `PlatformInfo`, all Android specific data is passed using `AndroidPlatformInfo` now. Removed the `Sized` bound for `PlatformInfo` so that user code can use `dyn PlatformInfo`, to avoid cfg-gating in multiple places.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#218 started taking in some Android specific information using a
PlatformInfofor instance creation, and #219 expanded that to also use thePlatformInfofor initializing the loader on Android.ndk-contextis still used to get theJavaVMpointer.That means we currently have the downsides of both
ndk-contextglobal has to be initializedThis PR removes the
ndk-contextdependency and passes all data explicitly using thePlatformInfo, including theJavaVMpointer.I also removed the
Sizedbound forPlatformInfoso that user code can usedyn PlatformInfo. That's not relevant for the examples in this repo, but for my usage this avoids cfg-gating in multiple places.