feat(deps): rework first-run overlay with step list, bytes, speed, and ETA#317
Open
Radexito wants to merge 13 commits into
Open
feat(deps): rework first-run overlay with step list, bytes, speed, and ETA#317Radexito wants to merge 13 commits into
Radexito wants to merge 13 commits into
Conversation
Tidal-dl-ng is a non-fatal optional dep — excluding it from totalSteps stops the "[1/1]" display bug that affected users who already had FFmpeg, analyzer, and yt-dlp installed (upgrade path). - Required steps: FFmpeg, analyzer, yt-dlp — counted and displayed as [N/M] - Optional step: tidal-dl-ng — displayed as [optional] prefix, not counted - When only optional dep is missing: no [N/M] prefix, just the message - Final message adapts: "Setup complete." vs "Dependencies up to date." Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…hed version files Settings showed "not installed" for deps that were present on disk because getInstalledVersions() read from internal .version JSON files that get wiped on "clear all data". Now each dep is probed by actually running the binary (ffmpeg -version, yt-dlp --version, analysis --version, tdn via findTidalDlPath), so the displayed status always reflects reality. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…local/bin uv tool install now runs with UV_TOOL_DIR and UV_TOOL_BIN_DIR pinned to userData/bin/ so tdn lands alongside ffmpeg and the analyzer. This makes "Clear all data" actually remove tidal-dl-ng, and keeps all managed binaries self-contained under DjManager's own folder. findTidalDlPath() probes the managed path first, then falls back to legacy system locations for pre-existing installs. Breaks the circular import between deps.js and tidalDlManager.js — deps.js now uses getTidalBinPath() directly; tidalDlManager.js computes the managed path via electron app.getPath(). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
tidal-dl-ng is optional. ensureDeps no longer downloads uv or installs tdn at startup. Installation happens on demand when the user first opens the Tidal tab (tidal-check IPC already calls ensureTidalDlNg). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…nalysis Back-calculated from native Rekordbox capture 20 (track with +2.6 dB loudness analysis): Unnamed7 = 0x4975 = 18805 → ref7 = 18805 / 10^(2.6/20) = 13940 Unnamed8 = 0x5DC9 = 24009 → ref8 = 24009 / 10^(2.6/20) = 17802 Previous values (19048 / 30967) were community-RE estimates that did not match observed native output. Refs #299. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…apture analysis" This reverts commit 3b2ba89.
39 tasks
… message - Early return was firing before tidal check, so tidal was never installed - 'Dependencies up to date.' was unreachable (totalSteps always > 0 at that point) - Restore tidal install block with [optional] prefix after required deps - New early return: only when totalSteps=0 AND tidalReady (true all-clear) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…rlay - Remove tidal from STEP_DEFS — excluded from required step count so it never shows a misleading [1/N] counter - Restore tidal optional install after required deps with [optional] prefix using structured object payload (stepId: null so overlay shows simple view) - Early return emits object payload when all deps already present - Final message: 'Setup complete.' vs 'Dependencies up to date.' depending on whether any required deps were downloaded - Bring in getTidalBinPath() and uvToolEnv() from fix/200 - getInstalledVersions() now probes real binaries instead of cached files Closes #237 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworks the first-run dependency download overlay and folds in the fixes from #237 (now closed).
[optional]after required deps finishgetInstalledVersions()probes real binaries instead of cached .version files — Settings shows correct version after "Clear all data""Setup complete."when deps were downloaded,"Dependencies up to date."when all already presentgetTidalBinPath()/uvToolEnv()manage tidal install in DjManager's own userData/binCloses #270
Closes #200
🤖 Generated with Claude Code