feat(download): adds auth to support new teehr-hub requirement#781
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Download client to support teehr-hub’s new authentication requirements (API key / bearer token) and adjusts pagination behavior to follow server-provided links (rel=next) when available. It also adds opt-in local integration testing guidance and markers.
Changes:
- Add
api_key/bearer_tokenconfiguration and send auth headers on outbound download requests. - Update pagination to prefer
links[rel=next]URLs and allow omittinglimitwhenpage_size=None. - Add
local_apipytest marker plus README guidance and new unit/integration tests covering auth + pagination.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/teehr/evaluation/download.py |
Adds auth header support and next-link pagination logic; updates page sizing defaults to allow server-controlled limits. |
tests/download/test_download.py |
Adds local_api-marked integration tests and new unit tests for auth headers + pagination behavior. |
tests/README.md |
Documents how to run opt-in local teehr-hub integration tests and required env vars/markers. |
pytest.ini |
Registers the new local_api marker. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@samlamont I addressed copilot comments. I think it is pretty good. |
samlamont
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.