Repository navigation
Add memory-mapped quantum RNG support to ROSS - #214
Open
sanjaychari wants to merge 3 commits into
Open
sanjaychari wants to merge 3 commits into
sanjaychari wants to merge 3 commits into
Conversation
Cancel and wait on outstanding posted MPI receives before finalizing MPI in tw_net_stop(). In multi-rank CODES runs, MPICH reported pending references on MPI_COMM_WORLD at shutdown even though the simulation completed correctly. The number of pending references scaled with ROSS's read-buffer size, indicating that the preposted MPI_Irecv requests were still active during MPI_Finalize(). Clean up those requests explicitly so conservative and optimistic CODES runs exit without the MPICH communicator reference warnings.
- Add optional QRNG backend while retaining CLCG4 as the default. - Use read-only mmap to access conditioned quantum random bits. - Partition the QRNG pool into non-overlapping blocks for LP RNG streams. - Assign blocks reproducibly using CLCG4-based Fisher-Yates shuffling. - Generate uniform random values from consecutive 53-bit segments. - Support optimistic rollback through reversible RNG cursors. - Add command-line configuration and debug output for block assignments.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #214 +/- ##
==========================================
- Coverage 48.75% 47.99% -0.77%
==========================================
Files 41 41
Lines 4816 4930 +114
Branches 861 889 +28
==========================================
+ Hits 2348 2366 +18
- Misses 2463 2559 +96
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #212