Skip to content

Fix int32 overflow in rotating buffer size calculation #2298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Z-Y00 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix int32 overflow in rotating buffer size calculation #2298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions tensilelite/client/src/DataInitialization.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2504,21 +2504,21 @@ namespace TensileLite
{
auto castInputs = static_pointer_cast<ContractionInputs>(inputs);
size_t rotatingSize = getRotatingSize(*gemmProblem, *castInputs);
int32_t rotatingNum
int64_t rotatingNum
= min(maxRotatingBufferNum, ceil((float)m_rotatingBuffer / rotatingSize))
- 1; // Minus the original buffer.

// <= 0 means don't rotating
rotatingNum = max(0, rotatingNum);
rotatingNum = max((int64_t)0, rotatingNum);

int32_t totalRotatingSizeNeeded = rotatingNum * rotatingSize;
int64_t totalRotatingSizeNeeded = rotatingNum * rotatingSize;
std::cout << "Rotating buffer set to: " << m_rotatingBuffer
<< ". Rotating num: " << rotatingNum << std::endl;
if(m_rotatingMode == 0)
{
auto rotatingAllocatedSize
= m_rm->getDataSize() - m_rm->getDataLargestUnitSize();
if(totalRotatingSizeNeeded > rotatingAllocatedSize)
if(totalRotatingSizeNeeded > (int64_t)rotatingAllocatedSize)
{
std::cout << "Rotating buffer size: " << rotatingAllocatedSize
<< " is not enough for rotating buffer size: " << rotatingSize
Expand Down Expand Up @@ -2566,21 +2566,21 @@ namespace TensileLite
rotatingSize
+= getRotatingSize(groupedProblem->gemms[i], castInputs->grouped[i]);
}
int32_t rotatingNum
int64_t rotatingNum
= min(maxRotatingBufferNum, ceil((float)m_rotatingBuffer / rotatingSize))
- 1; // Minus the original buffer.

// <= 0 means don't rotating
rotatingNum = max(0, rotatingNum);
rotatingNum = max((int64_t)0, rotatingNum);

int32_t totalRotatingSizeNeeded = rotatingNum * rotatingSize;
int64_t totalRotatingSizeNeeded = rotatingNum * rotatingSize;
std::cout << "Rotating buffer set to: " << m_rotatingBuffer
<< ". Rotating num: " << rotatingNum << std::endl;
if(m_rotatingMode == 0)
{
auto rotatingAllocatedSize
= m_rm->getDataSize() - m_rm->getDataLargestUnitSize();
if(totalRotatingSizeNeeded > rotatingAllocatedSize)
if(totalRotatingSizeNeeded > (int64_t)rotatingAllocatedSize)
{
std::cout << "Rotating buffer size: " << rotatingAllocatedSize
<< " is not enough for rotating buffer size: " << rotatingSize
Expand Down