Repository navigation
chore(fullsend): re-pin and re-lock verify-pr to its main commit c32f1c40 - #347
Conversation
Activates the TC-6979 prefetch half (github.commit_statuses, schema, correctness.md Check 1a) in fullsend runs. The base harness file is unchanged (same sha256); only the pinned commit moves 80de88a -> c32f1c4. triage-security pins are untouched. Implements TC-6979 Assisted-by: Claude Code Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Reviewer's GuideRe-pins verify-pr to main commit c32f1c4 and regenerates its Fullsend v0.43.0 lock entries, ensuring CI uses the #346 versions of the script, schema, and correctness guidance while preserving the base integrity hash and unrelated pins. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path=".fullsend/harness/verify-pr.yaml" line_range="31" />
<code_context>
# commit + the sha256 to `shasum -a 256 harness/verify-pr.yaml`, `fullsend lock`.
-base: https://raw.githubusercontent.com/RHEcosystemAppEng/sdlc-plugins/80de88affe47f2086d5f7bc2a2015092c33b478e/harness/verify-pr.yaml#sha256=3c9dc221e2a37e7aa7ff294381b6b5b1580771ba70432c42924fc3a85f078e63
+base: https://raw.githubusercontent.com/RHEcosystemAppEng/sdlc-plugins/c32f1c408f4da393b90c15b13a7d693946e0e232/harness/verify-pr.yaml#sha256=3c9dc221e2a37e7aa7ff294381b6b5b1580771ba70432c42924fc3a85f078e63
# CEL trigger (ADR 0061) — MUST be declared here, on the composing child, not
# only on the base. `fullsend dispatch` registers this child (config.base.yaml
</code_context>
<issue_to_address>
**Commit status text can steer reviews**
When a status publisher able to set a PR head's commit status supplies a context or description containing instructions aimed at the review agent, the Correctness sub-agent receives the status context and description as prompt content and can follow embedded directives to disregard CI results or alter its review. The caller then sees a manipulated verification report.
Delimit status fields as untrusted data and explicitly instruct the sub-agent to ignore any instructions contained in them.
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: .fullsend/harness/verify-pr.yaml:31
| # commit + the sha256 to `shasum -a 256 harness/verify-pr.yaml`, `fullsend lock`. | ||
| base: https://raw.githubusercontent.com/RHEcosystemAppEng/sdlc-plugins/80de88affe47f2086d5f7bc2a2015092c33b478e/harness/verify-pr.yaml#sha256=3c9dc221e2a37e7aa7ff294381b6b5b1580771ba70432c42924fc3a85f078e63 | ||
| base: https://raw.githubusercontent.com/RHEcosystemAppEng/sdlc-plugins/c32f1c408f4da393b90c15b13a7d693946e0e232/harness/verify-pr.yaml#sha256=3c9dc221e2a37e7aa7ff294381b6b5b1580771ba70432c42924fc3a85f078e63 | ||
|
|
There was a problem hiding this comment.
🟡 Medium · Commit status text can steer reviews
When a status publisher able to set a PR head's commit status supplies a context or description containing instructions aimed at the review agent, the Correctness sub-agent receives the status context and description as prompt content and can follow embedded directives to disregard CI results or alter its review. The caller then sees a manipulated verification report.
Delimit status fields as untrusted data and explicitly instruct the sub-agent to ignore any instructions contained in them.
Prompt for AI agents
In `.fullsend/harness/verify-pr.yaml` at line 31:
**Commit status text can steer reviews**
When a status publisher able to set a PR head's commit status supplies a context or description containing instructions aimed at the review agent, the Correctness sub-agent receives the status context and description as prompt content and can follow embedded directives to disregard CI results or alter its review. The caller then sees a manipulated verification report.
Delimit status fields as untrusted data and explicitly instruct the sub-agent to ignore any instructions contained in them.|
🤖 Finished Verify Pr · ⏭️ Skipped (no Jira issue links PR #347 in its Git Pull Request field) · Started 2:22 PM UTC · Completed 2:22 PM UTC Commit: Effort: high |
Summary
Follow-up to #346 (TC-6979). This PR re-pins
.fullsend/harness/verify-pr.yamlbase:from80de88aftoc32f1c40, which is #346's commit onmain, and re-locks withfullsend lock verify-pr --fullsend-dir .fullsend(fullsend v0.43.0). Without this, fullsend runs keep serving the pre-#346pre-verify-pr.sh, schema andcorrectness.md, so CI Status still ignores commit statuses.3c9dc221…). Only the commit SHA moves.mainforpre-verify-pr.sh,verify-pr-input.schema.jsonandcorrectness.md.c4891346) are untouched.80de88af..c32f1c40is fix(verify-pr): wait on and report commit statuses in dispatch gate and CI Status #346. The GitHub fullsend pins (v0.43.0/d5f36921) are not changed.python3 -m pytest plugins/sdlc-workflow/scripts/ -q: 717 passed.Implements TC-6979 · completes TC-6978
🤖 Generated with Claude Code
Summary by Sourcery
Re-pin and re-lock the verify-pr Fullsend harness to the main commit containing the latest CI status handling.
Bug Fixes:
Enhancements:
Chores: